Change step execution to be aware of pool granularity #27478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 3d67078. |
prha
force-pushed
the
prha/relax_op_slots
branch
2 times, most recently
from
3650bb9 to
0fb2d63
Compare
prha
force-pushed
the
prha/relax_op_slots
branch
from
0fb2d63 to
c8402f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Previously, op concurrency tags were only used to enforce limits for global op concurrency.
Now, with the introduction of pools, we support an API where pool limits are only enforced at the run level. This means that we are unnecessarily constraining ops at the op level.
This PR changes the behavior of op execution to no longer require the acquisition of a pool slot if the pool granularity is set for runs.
How I Tested These Changes
BK