[cli-refactor] Standardize shared option groups (part 2) #27494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smackesey
force-pushed
the
sean/workspace/consolidate-job-target
branch
from
12db08c to
a5d50b1
Compare
smackesey
force-pushed
the
sean/workspace/centralize-cli-utils
branch
from
740488a to
bccb744
Compare
smackesey
changed the title
smackesey
commented
Feb 3, 2025
| @@ -79,7 +81,7 @@ def job_cli(): | |||
| name="list", | |||
| help=f"List the jobs in a repository. {WORKSPACE_TARGET_WARNING}", | |||
| ) | |||
| @job_repository_target_options | |||
There was a problem hiding this comment.
This was identical to @repository_options, so it's been deleted.
smackesey
force-pushed
the
sean/workspace/consolidate-job-target
branch
from
a5d50b1 to
5d7ae2e
Compare
smackesey
force-pushed
the
sean/workspace/centralize-cli-utils
branch
from
bccb744 to
10e3127
Compare
smackesey
force-pushed
the
sean/workspace/centralize-cli-utils
branch
from
10e3127 to
0902df7
Compare
smackesey
force-pushed
the
sean/workspace/consolidate-job-target
branch
from
5d7ae2e to
2ba5094
Compare
Base automatically changed from
sean/workspace/centralize-cli-utils
to
master
February 3, 2025 13:53
smackesey
force-pushed
the
sean/workspace/consolidate-job-target
branch
from
2ba5094 to
5ab09e4
Compare
smackesey
commented
Feb 3, 2025
| ) | ||
|
|
||
|
|
||
| @validate_command_options |
There was a problem hiding this comment.
[1] validate_command_options here is just an arbitrary subset of the full set of workspace options. AFAICT there is no reason for this, since we immediately resolve these options to a workspace using the common pathway inside the validate command. Therefore replace with standard workspace options.
smackesey
commented
Feb 3, 2025
| generate_module_name_option(allow_multiple=True), | ||
| generate_working_directory_option(), | ||
| *generate_grpc_server_target_options(hidden=True), | ||
| ) |
smackesey
force-pushed
the
sean/workspace/consolidate-job-target
branch
from
5ab09e4 to
a58be30
Compare
smackesey
changed the title
smackesey
force-pushed
the
sean/workspace/consolidate-job-target
branch
from
a58be30 to
9c0b023
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Comment on lines
256
to
257
| if kwargs.get("empty_workspace"): | ||
| args.extend("--empty-workspace") |
There was a problem hiding this comment.
args.extend() is being called with a string argument, which Python will iterate through character-by-character. To properly add the flag as a single argument, use either args.extend(['--empty-workspace']) or args.extend(('--empty-workspace',)).
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
smackesey
force-pushed
the
sean/workspace/consolidate-job-target
branch
2 times, most recently
from
0b89790 to
97522d5
Compare
schrockn
approved these changes
Feb 3, 2025
smackesey
force-pushed
the
sean/workspace/consolidate-job-target
branch
from
97522d5 to
175147a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
@repository_target_options->@repository_options). This was confusing since it didn't correspond to actual*Target*classes in the code.@python_origin_target_options->@python_pointer_options. "pointer" was chosen because the Python pointer options mostly correspond (and are ultimately parsed to)CodePointerobjects.@python_job_config_option->@run_config_option. Another misleading name, as this was used outside the context of job config.dagster definitions validateaccepted--workspace,--python-file, and--module-namebut none of the other workspace-specifying options. There's no apparent reason for this, since the function resolves a workspace for validation. The inconsistency was likely the result of the original implementor just getting overwhelmed with the complexity of the code.How I Tested These Changes
Existing test suite.