Use a slightly faster computation for sqrt_ratio_i. #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I found this on the CFRG mailing list: it seems correct, and the tests still pass. See comment for references.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found this on the CFRG mailing list: it seems correct, and the
tests still pass. See comment for references, including CFRG
discussion.
This improvement appears to have a modest improvement to Ed25519 decompression,
at least for me on M1:
Benchmarking EdwardsPoint decompression
Benchmarking EdwardsPoint decompression: Warming up for 3.0000 s
Benchmarking EdwardsPoint decompression: Collecting 100 samples in estimated 5.0
058 s (1.4M iterations)
Benchmarking EdwardsPoint decompression: Analyzing
EdwardsPoint decompression
time: [3.5282 us 3.5387 us 3.5494 us]
change: [-2.1564% -1.8729% -1.5866%] (p = 0.00 < 0.05)
Performance has improved.