Fix error for custom targets #510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rozbb
requested changes
Mar 9, 2023
|
This RP does not fix #508. The logic is pretty much the same is before but with nicer error messages. The issue is that I can't set |
|
Referring back to: #508 (comment) I suspect the custom build tools which are not part of Rust are not signalling the right cfg's to rustc as it works with standard rustc tooling. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #508
Supercedes #509
Desired behaviour is to require explicit setting in case of custom targets and give our helpful error message.
Also clears out the unwrap for missing standard TARGET in case of being used in non-Cargo build system.