Update dependencies #87
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d-and-curve25519 Dependency updates, fixes for nightly-2021-07-21
remoun
commented
Feb 16, 2022
| @@ -59,3 +58,6 @@ u64_backend = ["curve25519-dalek/u64_backend"] | |||
| u32_backend = ["curve25519-dalek/u32_backend"] | |||
| fiat_u64_backend = ["curve25519-dalek/fiat_u64_backend"] | |||
| fiat_u32_backend = ["curve25519-dalek/fiat_u32_backend"] | |||
|
|
|||
| [patch.crates-io] | |||
| curve25519-dalek = { git = "https://github.com/mobilecoinfoundation/curve25519-dalek.git", rev = "8791722e0273762552c9a056eaccb7df6baf44d7" } | |||
There was a problem hiding this comment.
This can be removed once dalek-cryptography/curve25519-dalek#383 is merged and published.
rkuhn
reviewed
Dec 2, 2022
| # `serde` is renamed to `our_serde` in order to avoid a name collision between | ||
| # importing the serde dependency and enabling the curve25519-dalek/serde feature | ||
| our_serde = { package = "serde", version = "1", default-features = false, optional = true, features = ["derive"] } | ||
| zeroize = { version = "=1.3", default-features = false, features = ["zeroize_derive"] } | ||
| zeroize = { version = "1", default-features = false, features = ["zeroize_derive"] } |
There was a problem hiding this comment.
This patch would unblock the coexistence of this crate with elliptic-curve. What would it take to get it released?
There was a problem hiding this comment.
It needs to be updated to use dalek-cryptography/curve25519-dalek#405 once that's released
|
Subsumed by #95 . Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update all deps to latest.