Load main page content in order #139
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damontecres
added
the
user interface
damontecres
added a commit
that referenced
this pull request
Feb 24, 2024
Replaces #139 After #131 & #133, the rows on the main page load asynchronously. And the first one to load grabs the focus of the page which is not ideal. This PR refactors so that all of the data is fetch asynchronously, but added to the UI in order. Additionally, in the event of failures, focus will be moved to the top bar. Before focus would be lost and you have to press up to get to the bar to scroll over the settings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #131 & #133, the rows on the main page load asynchronously. And the first one to load grabs the focus of the page which is not ideal.
This PR forces the rows to be loaded sequentially so the focus stays on the first row.
A better approach would probably be to figure out a way to still run async but control the focus better or focus on the search button. So far haven't found a way to do this.