UI/UX Improvements #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damontecres
added
the
user interface
damontecres
added a commit
that referenced
this pull request
Feb 10, 2024
Add fontawesome and use the same icons that the server web UI does on the scene cards rather than the unicode ones added in #61. Also adds the studio name if available to the card until #89 can be done. Here's what it looks like now: <img width="257" alt="Screenshot" src="https://github.com/damontecres/StashAppAndroidTV/assets/154766448/d22e52cb-ba7a-4f4a-adaa-b04769e4109a">
This was referenced Apr 18, 2024
damontecres
added a commit
that referenced
this pull request
May 25, 2024
The server will provide a stream labelled "Direct stream", but this is aimed towards the web UI player. In some cases, an Android TV device can direct play the video even when the web UI cannot. This PR changes the direct play vs transcode decision. The app will check what video/audio codecs the device reports as able to decode. If the video has a supported video codec and supported audio codec, the app will attempt to play the video directly no matter what. A user can still force transcoding (#61) if needed. This PR also adds the ability to force a direct play as well. In advanced settings, a user can specify specific codecs which should be considered as supported for direct play even if the device doesn't report them as supported (`ac3` and `pcm` audio is a good example of this). Several audio codecs are included in this list by default, but can be removed if needed. That said, the attempt is just that, an attempt. Since the server does not expose finer grained parameters, such as H264 profiles/levels, these parameters are _not_ considered in the decision. This means some videos may not actually direct play, but users can force the transcode in these situations. Finally, there is an advanced setting to enable a debug overlay during playback which explains the decision to direct play vs transcode. Closes #270 Related to #59, #232, & #233 Ref: - https://developer.android.com/media/platform/supported-formats - https://developer.android.com/media/media3/exoplayer/supported-formats
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Demo:
stashapp.mp4