Fix activity tracking for Exo Player #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damontecres
added a commit
that referenced
this pull request
Feb 25, 2024
In #81, scene details were updated to fetch during `onResume` which meant that all of the markers, performers, etc would be reset. This meant everything could flash for a second. Also meant that the selected item would revert to the beginning of the list. So this PR moves the initial fetch of scene data to `onViewCreated` and does a refresh in `onResume` so those UI glitches won't happen. This PR also moves some of the UI initialization to _before_ fetching the scene data and removes the temporary background image so there isn't a strange color swap.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #80
I had thought it was just a UI glitch that scene resume times weren't updating, but turns out the new player in #62 did not implement the tracking at all.
This PR adds the tracking to the new player if tracking is enabled server side. Additionally, a rough implementation copy of the tracking from the server is added to increment play count, except the timer runs every 10s instead 1s. This change only applies to the new ExoPlayer, not the old default player.
Also scene details are fetched every time on the video details page instead of using the caller's data (which might be outdated). This ensures the latest resume time is available.