Enable unlimited size timelines without affecting performance #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: William Casarin <[email protected]>
absolutely insane performance increase Fixes: #32 Suggested-by: @lucasmerlin Signed-off-by: William Casarin <[email protected]>
kernelkind
reviewed
Apr 28, 2024
| let list = app.timelines[timeline].list.clone(); | ||
| list.lock() | ||
| .unwrap() | ||
| .ui_custom_layout(ui, len, |ui, start_index| { |
There was a problem hiding this comment.
Love this, closure for each note. Looks like VirtualList has some other useful methods as well for managing the state of the timeline. Seems like a perfect use-case for us
There was a problem hiding this comment.
noticing a bit of glitchiness in a few cases, but I can look into those later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses egui_virtual_list by @lucasmerlin. It is absolutely amazing.