Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove reqwest #567

Closed
wants to merge 3 commits into from
Closed

Remove reqwest #567

wants to merge 3 commits into from

Conversation

kernelkind
Copy link
Member

@kernelkind kernelkind commented Dec 12, 2024 •
edited
Loading

Removes reqwest dependency completely

  • revert login manager to just use promises with ehttp instead of reqwest and remove the dependencies from our Cargo.tomls.
  • only use std and nip49 from nostr
  • use bech32 package directly instead of relying on nostrs

jb55 pushed a commit that referenced this pull request Dec 13, 2024
@kernelkind @jb55
remove reqwest explicitly from toml
2c2eed0 
Closes: #567
Signed-off-by: kernelkind <[email protected]>
jb55 pushed a commit that referenced this pull request Dec 13, 2024
@kernelkind @jb55
remove reqwest dep from nostr
f9429ae 
Signed-off-by: kernelkind <[email protected]>

Closes: #567
jb55 pushed a commit that referenced this pull request Dec 13, 2024
@kernelkind @jb55
deps: remove reqwest
13a406b 
This was preventing us from building on windows amd

Closes: #567
Signed-off-by: kernelkind <[email protected]>
Signed-off-by: William Casarin <[email protected]>
@jb55 jb55 closed this in 4bfa26f Dec 13, 2024
@jb55
Copy link
Contributor

jb55 commented Dec 13, 2024

turns out ab829b4 was the real issue, but at least we have less deps now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kernelkind @jb55