Notes and replies filters #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also update some other deps Signed-off-by: William Casarin <[email protected]>
Signed-off-by: William Casarin <[email protected]>
Instead of calling ctx.input multiple times, let's do it once. We are going to do a lot more stuff in here, such as vim key bindings
Calling key_pressed invokes a filter over the entire event list every time, this is much more efficient, which is important when we are handling many key events.
TimelineView is a filtered view of a timeline. We will use this for future tab rendering. We also introduce a new "selection" concept for selecting notes on different timeline views. This is in preparation for vim keybindings.
we don't have any multithreaded stuff yet Signed-off-by: William Casarin <[email protected]>
Signed-off-by: William Casarin <[email protected]>
Signed-off-by: William Casarin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds no-reply filters to timeline views.