Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Google analytics tag to environment variable to prevent DANDI clones using by accident #2126

Merged
merged 2 commits into from
Jan 22, 2025
Merged

Move Google analytics tag to environment variable to prevent DANDI clones using by accident #2126

merged 2 commits into from
Jan 22, 2025

Conversation

aaronkanzer
Copy link
Member

@aaronkanzer aaronkanzer mentioned this pull request Jan 2, 2025
Merged
1 task
@kabilar kabilar requested a review from waxlamp January 2, 2025 21:41
@kabilar kabilar linked an issue Jan 2, 2025 that may be closed by this pull request
Move Google Analytics tag to an environment variable #2016
Closed
kabilar
kabilar reviewed Jan 6, 2025
View reviewed changes
Copy link
Member

@kabilar kabilar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Aaron. This looks good to me.

waxlamp
waxlamp requested changes Jan 20, 2025
View reviewed changes
Copy link
Member

@waxlamp waxlamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good improvement, but it doesn't prevent clones from pushing data to the wrong GA sink, right?

web/src/main.ts Outdated Show resolved Hide resolved
@waxlamp waxlamp added patch Increment the patch version when merged release Create a release when this pr is merged labels Jan 22, 2025
@waxlamp waxlamp merged commit 0778577 into master Jan 22, 2025
4 checks passed
@waxlamp waxlamp deleted the ak-analytics branch January 22, 2025 16:49
@dandibot
Copy link
Member

🚀 PR was released in v0.4.12 🚀

@dandibot dandibot added the released This issue/pull request has been released. label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kabilar kabilar kabilar left review comments

@waxlamp waxlamp waxlamp approved these changes

Assignees
No one assigned
Labels
patch Increment the patch version when merged release Create a release when this pr is merged released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move Google Analytics tag to an environment variable
4 participants
@aaronkanzer @dandibot @kabilar @waxlamp