Merge pull request #705 from sgtcoolguy/bitbucket-pending

Fix handling of 'pending' status for BitBucket's updateStatus()
danger · Nov 5, 2018 · 1e34f3b · 1e34f3b
2 parents 3419b64 + c931a5e
commit 1e34f3b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -13,6 +13,7 @@
 
 ## Master
 
+- Fix handling a `"pending"` status update properly using Bitbucket API - [@sgtcoolguy][]
 - Fix #614 - Posting status updates to Github using issue workflow broken - [@sgtcoolguy][]
 - Fix vertical alignment in GitHub issue template - [@patrickkempff][]
 

diff --git a/source/platforms/BitBucketServer.ts b/source/platforms/BitBucketServer.ts
@@ -42,9 +42,13 @@ export class BitBucketServer implements Platform {
   updateStatus = async (passed: boolean | "pending", message: string, url?: string): Promise<boolean> => {
     const pr = await this.api.getPullRequestInfo()
     const { latestCommit } = pr.fromRef
+    let state = passed ? "SUCCESSFUL" : "FAILED"
+    if (passed === "pending") {
+      state = "INPROGRESS"
+    }
     try {
       await this.api.postBuildStatus(latestCommit, {
-        state: passed ? "SUCCESSFUL" : "FAILED",
+        state: state,
         key: "danger.systems",
         name: process.env["PERIL_INTEGRATION_ID"] ? "Peril" : "Danger",
         url: url || "http://danger.systems/js",