Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kubernetes deployment reference #234

Merged
merged 3 commits into from
Oct 28, 2018

Conversation

icicimov
Copy link
Contributor

As per our discussion, adding the Kubernetes deployment reference as subsection.

Cheers,
Igor

@mprasil
Copy link
Contributor

mprasil commented Oct 26, 2018

For reference, we're talking about discussion here.

@icicimov sorry for not being clear there. I think it would be better to actually add some small description and link to the repository in the document rather than just linking to it from the TOC as people generally don't expect TOC to link to different document. (and also is autogenerated) Hope that makes sense.

@icicimov
Copy link
Contributor Author

I'm sorry, it was getting late here and I was too tired. A properly done PR will follow shortly.

@mprasil
Copy link
Contributor

mprasil commented Oct 27, 2018

That's perfect, just one typo: bitworden_rs should be bitwarden_rs.

@dani-garcia
Copy link
Owner

Thanks icicimov!

@dani-garcia dani-garcia merged commit 1bdb98d into dani-garcia:master Oct 28, 2018
thelittlefireman pushed a commit to thelittlefireman/bitwarden_rs that referenced this pull request Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants