delete go loop copy vars

danicc097 · Jan 19, 2025 · a5f2b14 · a5f2b14
1 parent 5d14948
commit a5f2b14
Show file tree

Hide file tree

Showing 23 changed files with 1 addition and 38 deletions.
diff --git a/bin/templates/crud-api-tests.go.tmpl.bash b/bin/templates/crud-api-tests.go.tmpl.bash
@@ -56,7 +56,6 @@ $(test -n "$with_project" && echo "		pj := models.ProjectNameDemo
 		},
 	}
 	for _, tc := range tests {
-		tc := tc
 		t.Run(tc.name, func(t *testing.T) {
 			t.Parallel()
 			ufixture := ff.CreateUser(context.Background(), servicetestutil.CreateUserParams{
@@ -217,7 +216,6 @@ done)
 		// },
 	}
 	for _, tc := range tests {
-		tc := tc
 		t.Run(tc.name, func(t *testing.T) {
 			t.Parallel()
 

diff --git a/bin/templates/crud-repo-tests.go.tmpl.bash b/bin/templates/crud-repo-tests.go.tmpl.bash
@@ -58,7 +58,6 @@ $(test -n "$with_project" && echo "	projectID := internal.ProjectIDByName[models
 		},
 	}
 	for _, tc := range tests {
-		tc := tc
 		t.Run(tc.name, func(t *testing.T) {
 			t.Parallel()
 
@@ -112,7 +111,6 @@ func Test${pascal_name}_${delete_method}(t *testing.T) {
 		},
 	}
 	for _, tc := range tests {
-		tc := tc
 		t.Run(tc.name, func(t *testing.T) {
 			t.Parallel()
 
@@ -154,7 +152,6 @@ func Test${pascal_name}_ByIndexedQueries(t *testing.T) {
 		},
 	}
 	for _, tc := range uniqueTestCases {
-		tc := tc
 		runGenericFilterTests(t, tc)
 	}
 }

diff --git a/bin/templates/crud-service-tests.go.tmpl.bash b/bin/templates/crud-service-tests.go.tmpl.bash
@@ -82,7 +82,6 @@ done)
 	}
 
 	for _, tc := range tests {
-		tc := tc
 		t.Run(tc.name, func(t *testing.T) {
 			t.Parallel()
 

diff --git a/internal/codegen/codegen_test.go b/internal/codegen/codegen_test.go
@@ -54,7 +54,6 @@ func TestAnalyzeSpec(t *testing.T) {
 	}
 
 	for _, tc := range cases {
-		tc := tc
 		t.Run(tc.name, func(t *testing.T) {
 			t.Parallel()
 
@@ -222,7 +221,6 @@ func (h *StrictHandlers) Bar() {
 		// },
 	}
 	for _, tc := range tests {
-		tc := tc
 		t.Run(tc.name, func(t *testing.T) {
 			t.Parallel()
 

diff --git a/internal/repos/postgresql/repo_activity_test.go b/internal/repos/postgresql/repo_activity_test.go
@@ -53,7 +53,6 @@ func TestActivity_ByIndexedQueries(t *testing.T) {
 		},
 	}
 	for _, tc := range uniqueTestCases {
-		tc := tc
 		runGenericFilterTests(t, tc)
 	}
 
@@ -68,7 +67,6 @@ func TestActivity_ByIndexedQueries(t *testing.T) {
 		},
 	}
 	for _, tc := range nonUniqueTestCases {
-		tc := tc
 		runGenericFilterTests(t, tc)
 	}
 }
diff --git a/internal/repos/postgresql/repo_kanban_step_test.go b/internal/repos/postgresql/repo_kanban_step_test.go
@@ -26,7 +26,6 @@ func TestKanbanStep_ByIndexedQueries(t *testing.T) {
 		},
 	}
 	for _, tc := range uniqueTestCases {
-		tc := tc
 		runGenericFilterTests(t, tc)
 	}
 
@@ -50,7 +49,6 @@ func TestKanbanStep_ByIndexedQueries(t *testing.T) {
 		},
 	}
 	for _, tc := range nonUniqueTestCases {
-		tc := tc
 		runGenericFilterTests(t, tc)
 	}
 }
diff --git a/internal/repos/postgresql/repo_project_test.go b/internal/repos/postgresql/repo_project_test.go
@@ -39,7 +39,6 @@ func TestProject_ByIndexedQueries(t *testing.T) {
 		},
 	}
 	for _, tc := range uniqueTestCases {
-		tc := tc
 		runGenericFilterTests(t, tc)
 	}
 }

diff --git a/internal/repos/postgresql/repo_team_test.go b/internal/repos/postgresql/repo_team_test.go
@@ -49,7 +49,6 @@ func TestTeam_ByIndexedQueries(t *testing.T) {
 		},
 	}
 	for _, tc := range uniqueTestCases {
-		tc := tc
 		runGenericFilterTests(t, tc)
 	}
 }
@@ -122,7 +121,6 @@ func TestTriggers_sync_user_teams(t *testing.T) {
 		},
 	}
 	for _, tc := range testCases {
-		tc := tc
 		t.Run(tc.name, func(t *testing.T) {
 			t.Parallel()
 

diff --git a/internal/repos/postgresql/repo_time_entry_test.go b/internal/repos/postgresql/repo_time_entry_test.go
@@ -34,7 +34,6 @@ func TestTimeEntry_ByIndexedQueries(t *testing.T) {
 		},
 	}
 	for _, tc := range uniqueTestCases {
-		tc := tc
 		runGenericFilterTests(t, tc)
 	}
 

diff --git a/internal/repos/postgresql/repo_user_test.go b/internal/repos/postgresql/repo_user_test.go
@@ -52,7 +52,6 @@ func TestUser_Update(t *testing.T) {
 		},
 	}
 	for _, tc := range tests {
-		tc := tc
 		t.Run(tc.name, func(t *testing.T) {
 			t.Parallel()
 
@@ -109,7 +108,6 @@ func TestUser_SoftDelete(t *testing.T) {
 		},
 	}
 	for _, tc := range tests {
-		tc := tc
 		t.Run(tc.name, func(t *testing.T) {
 			t.Parallel()
 
@@ -192,7 +190,6 @@ func TestUser_ByIndexedQueries(t *testing.T) {
 		},
 	}
 	for _, tc := range uniqueTestCases {
-		tc := tc
 		runGenericFilterTests(t, tc)
 	}
 
@@ -227,7 +224,6 @@ func TestUser_ByIndexedQueries(t *testing.T) {
 		},
 	}
 	for _, tc := range nonUniqueTestCases {
-		tc := tc
 		runGenericFilterTests(t, tc)
 	}
 }

diff --git a/internal/repos/postgresql/repo_work_item_comment_test.go b/internal/repos/postgresql/repo_work_item_comment_test.go
@@ -48,7 +48,6 @@ func TestWorkItemComment_Update(t *testing.T) {
 		},
 	}
 	for _, tc := range tests {
-		tc := tc
 		t.Run(tc.name, func(t *testing.T) {
 			t.Parallel()
 
@@ -101,7 +100,6 @@ func TestWorkItemComment_Delete(t *testing.T) {
 		},
 	}
 	for _, tc := range tests {
-		tc := tc
 		t.Run(tc.name, func(t *testing.T) {
 			t.Parallel()
 
@@ -141,7 +139,6 @@ func TestWorkItemComment_ByIndexedQueries(t *testing.T) {
 		},
 	}
 	for _, tc := range uniqueTestCases {
-		tc := tc
 		runGenericFilterTests(t, tc)
 	}
 }

diff --git a/internal/repos/postgresql/repo_work_item_project_demo_test.go b/internal/repos/postgresql/repo_work_item_project_demo_test.go
@@ -46,7 +46,6 @@ func TestDemoWorkItem_Update(t *testing.T) {
 		},
 	}
 	for _, tc := range tests {
-		tc := tc
 		t.Run(tc.name, func(t *testing.T) {
 			t.Parallel()
 

diff --git a/internal/repos/postgresql/repo_work_item_project_demo_two_test.go b/internal/repos/postgresql/repo_work_item_project_demo_two_test.go
@@ -49,7 +49,6 @@ func TestDemoTwoWorkItem_Update(t *testing.T) {
 		},
 	}
 	for _, tc := range tests {
-		tc := tc
 		t.Run(tc.name, func(t *testing.T) {
 			t.Parallel()
 

diff --git a/internal/repos/postgresql/repo_work_item_tag_test.go b/internal/repos/postgresql/repo_work_item_tag_test.go
@@ -37,7 +37,6 @@ func TestWorkItemTag_ByIndexedQueries(t *testing.T) {
 		},
 	}
 	for _, tc := range uniqueTestCases {
-		tc := tc
 		runGenericFilterTests(t, tc)
 	}
 }
diff --git a/internal/repos/postgresql/repo_work_item_type_test.go b/internal/repos/postgresql/repo_work_item_type_test.go
@@ -37,7 +37,6 @@ func TestWorkItemType_ByIndexedQueries(t *testing.T) {
 		},
 	}
 	for _, tc := range uniqueTestCases {
-		tc := tc
 		runGenericFilterTests(t, tc)
 	}
 }
diff --git a/internal/rest/api_user_test.go b/internal/rest/api_user_test.go
@@ -51,7 +51,6 @@ func TestHandlers_DeleteUser(t *testing.T) {
 		},
 	}
 	for _, tc := range tests {
-		tc := tc
 		t.Run(tc.name, func(t *testing.T) {
 			t.Parallel()
 			ufixture := ff.CreateUser(context.Background(), servicetestutil.CreateUserParams{
@@ -233,7 +232,6 @@ func TestHandlers_UpdateUser(t *testing.T) {
 		},
 	}
 	for _, tc := range tests {
-		tc := tc
 		t.Run(tc.name, func(t *testing.T) {
 			t.Parallel()
 

diff --git a/internal/rest/api_work_item.go b/internal/rest/api_work_item.go
@@ -98,7 +98,7 @@ func (h *StrictHandlers) CreateWorkitem(c *gin.Context, request CreateWorkitemRe
 
 	var resJson *CreateWorkitem201JSONResponse
 	json.Unmarshal(rawMessage(res), &resJson)
-	return *resJson, nil
+	return resJson, nil
 }
 
 func (h *StrictHandlers) GetWorkItem(c *gin.Context, request GetWorkItemRequestObject) (GetWorkItemResponseObject, error) {

diff --git a/internal/rest/api_work_item_comment_test.go b/internal/rest/api_work_item_comment_test.go
@@ -46,7 +46,6 @@ func TestHandlers_DeleteWorkItemComment(t *testing.T) {
 		},
 	}
 	for _, tc := range tests {
-		tc := tc
 		t.Run(tc.name, func(t *testing.T) {
 			t.Parallel()
 
@@ -205,7 +204,6 @@ func TestHandlers_UpdateWorkItemComment(t *testing.T) {
 		},
 	}
 	for _, tc := range tests {
-		tc := tc
 		t.Run(tc.name, func(t *testing.T) {
 			t.Parallel()
 

diff --git a/internal/rest/api_work_item_tag_test.go b/internal/rest/api_work_item_tag_test.go
@@ -42,7 +42,6 @@ func TestHandlers_CreateWorkItemTag(t *testing.T) {
 		},
 	}
 	for _, tc := range tests {
-		tc := tc
 		t.Run(tc.name, func(t *testing.T) {
 			t.Parallel()
 

diff --git a/internal/rest/middleware.auth_test.go b/internal/rest/middleware.auth_test.go
@@ -95,7 +95,6 @@ func TestAuthorizationMiddleware(t *testing.T) {
 	svcs := services.New(logger, services.CreateTestRepos(t), testPool)
 
 	for _, tc := range testCases {
-		tc := tc
 		t.Run(tc.name, func(t *testing.T) {
 			t.Parallel()
 			res := httptest.NewRecorder()

diff --git a/internal/services/service_user_test.go b/internal/services/service_user_test.go
@@ -87,7 +87,6 @@ func TestUser_UpdateUser(t *testing.T) {
 	}
 
 	for _, tc := range tests {
-		tc := tc
 		t.Run(tc.name, func(t *testing.T) {
 			t.Parallel()
 
@@ -286,7 +285,6 @@ func TestUser_UpdateUserAuthorization(t *testing.T) {
 	}
 
 	for _, tc := range tests {
-		tc := tc
 		t.Run(tc.name, func(t *testing.T) {
 			t.Parallel()
 

diff --git a/internal/services/service_work_item_comment_test.go b/internal/services/service_work_item_comment_test.go
@@ -54,7 +54,6 @@ func TestWorkItemComment_Update(t *testing.T) {
 		},
 	}
 	for _, tc := range tests {
-		tc := tc
 		t.Run(tc.name, func(t *testing.T) {
 			t.Parallel()
 

diff --git a/internal/services/service_work_item_tag_test.go b/internal/services/service_work_item_tag_test.go
@@ -90,7 +90,6 @@ func TestWorkItemTag_Update(t *testing.T) {
 	}
 
 	for _, tc := range tests {
-		tc := tc
 		t.Run(tc.name, func(t *testing.T) {
 			t.Parallel()
-Original file line number
+Diff line change
@@ Expand Up / @@ -39,7 +39,6 @@ func TestProject_ByIndexedQueries(t *testing.T) { @@
     		},
     	}
     	for _, tc := range uniqueTestCases {
-    		tc := tc
     		runGenericFilterTests(t, tc)
     	}
     }
@@ Expand Down @@