Skip to content
This repository has been archived by the owner on May 8, 2020. It is now read-only.

Fix for WordPress OAuth server #9

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

davidatwhiletrue
Copy link

WordPress http response to http://server/oauth1/request returns and additional CRLF between header and body. This leads to a dictionary having a key like \noauth_token.

Example:

HTTP/1.1 200 OK
Server: nginx/1.10.1
Date: Thu, 31 Aug 2017 14:55:24 GMT
Content-Type: application/x-www-form-urlencoded; charset=utf-8
Transfer-Encoding: chunked
Connection: close
X-Powered-By: PHP/7.0.3
Access-Control-Allow-Headers: Authorization


oauth_token=BtgsncIT13hQuTEWsV2kYjYo&oauth_token_secret=uJNSLX2rNdeIFYlZad2rVFgeqKU6c6bUkjA1T3bZSBUOiVxq&oauth_callback_confirmed=true

This pull request modifies the creation of the dictionary to remove leading CRLF in keys while creating the response parameter dictionary.

As much as I've tried to identify why this happens in WordPress side I've not been able to remove the extra CRLF there. I get some behaviour with Apache and nginx. Therefore, it might be useful to have this fix in DCTAuth.

Regards,

David Hernando

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant