Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed #13504 - fixed cppcheckexecutorseh.cpp compilation without precompiled headers #7152

Merged
merged 1 commit into from
Jan 4, 2025

Conversation

firewave
Copy link
Collaborator

@firewave firewave commented Jan 1, 2025

No description provided.

@firewave
Copy link
Collaborator Author

firewave commented Jan 1, 2025

Reported in conda-forge/cppcheck-feedstock#97 (comment).

I did not open a PR against the trunk because this is made obsolete by #7145.

@firewave firewave changed the title cppcheckexecutorseh.cpp: fixed compilation without precompiled headers fixed #13504 - cppcheckexecutorseh.cpp: fixed compilation without precompiled headers Jan 1, 2025
@firewave firewave changed the title fixed #13504 - cppcheckexecutorseh.cpp: fixed compilation without precompiled headers fixed #13504 - fixed cppcheckexecutorseh.cpp compilation without precompiled headers Jan 1, 2025
@firewave
Copy link
Collaborator Author

firewave commented Jan 1, 2025

@danmar the premium workflow fails with Invalid license: License has expired. Contact [email protected].

@firewave firewave marked this pull request as draft January 1, 2025 17:16
@danmar
Copy link
Owner

danmar commented Jan 1, 2025

@danmar the premium workflow fails with Invalid license: License has expired. Contact [email protected].

The license needs to be updated.. can you try to use the license I added in 588ca87 ?

@danmar
Copy link
Owner

danmar commented Jan 2, 2025

@firewave hmm I tried to update the license file with #7161 but I get CI issues. I don't know if there is a quick simple fix..

@firewave
Copy link
Collaborator Author

firewave commented Jan 4, 2025

@firewave hmm I tried to update the license file with #7161 but I get CI issues. I don't know if there is a quick simple fix..

Those were the jobs with the no longer supported distros. GitHub completely removed support at the end of the year so it fails. Will remove them.

@firewave firewave marked this pull request as ready for review January 4, 2025 18:44
@firewave firewave merged commit 1f61c2e into danmar:2.16.x Jan 4, 2025
62 checks passed
@firewave firewave deleted the seh-vs-2.16.x branch January 4, 2025 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants