fixed #13343 - Bump cmake_minimum_required() to 3.13
#7213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
firewave
requested changes
Jan 13, 2025
There was a problem hiding this comment.
I checked https://pkgs.org and the notes in #3596 and bumping it further up to 3.13 should be no problem. So the additional cmake_minimum_required() is no longer required.
Please also update readme.md. And there is several CMAKE_VERSION checks which can be removed.
rouault
force-pushed
the
update_cmake_min
branch
from
cbca244 to
45349b7
Compare
rouault
changed the title
and do associated cleanups. Fixes #13343 Recent CMake versions emit: ``` CMake Deprecation Warning at CMakeLists.txt:1 (cmake_minimum_required): Compatibility with CMake < 3.10 will be removed from a future version of CMake. Update the VERSION argument <min> value. Or, use the <min>...<max> syntax to tell CMake that the project requires at least <min> but has been updated to work with policies introduced by <max> or earlier. ```
rouault
force-pushed
the
update_cmake_min
branch
from
45349b7 to
7e9c5fc
Compare
done |
firewave
changed the title
firewave
changed the title
cmake_minimum_required() to 3.13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and do associated cleanups.
Fixes #13343
Recent CMake versions emit: