-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement _check #2111
base: ChSaiPavanJaswanth
Are you sure you want to change the base?
Implement _check #2111
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,48 +1,34 @@ | ||
exports._check = () => { | ||
exports._check = (x,y) => { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. A space is required after ','. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. exports._check = (x, y) => { // Ensure there's a space after the comma |
||
if (typeof x !== 'number') { | ||
throw new TypeError(`${x} is not a number`); | ||
} | ||
if (typeof y !== 'number') { | ||
throw new TypeError(`${y} is not a number`); | ||
} | ||
// DRY up the codebase with this function | ||
// First, move the duplicate error checking code here | ||
// Then, invoke this function inside each of the others | ||
// HINT: you can invoke this function with exports._check() | ||
}; | ||
|
||
exports.add = (x, y) => { | ||
if (typeof x !== 'number') { | ||
throw new TypeError(`${x} is not a number`); | ||
} | ||
if (typeof y !== 'number') { | ||
throw new TypeError(`${y} is not a number`); | ||
} | ||
exports._check(x,y); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. A space is required after ','. |
||
return x + y; | ||
}; | ||
|
||
exports.subtract = (x, y) => { | ||
if (typeof x !== 'number') { | ||
throw new TypeError(`${x} is not a number`); | ||
} | ||
if (typeof y !== 'number') { | ||
throw new TypeError(`${y} is not a number`); | ||
} | ||
exports._check(x,y); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. A space is required after ','. |
||
return x - y; | ||
}; | ||
|
||
exports.multiply = (x, y) => { | ||
if (typeof x !== 'number') { | ||
throw new TypeError(`${x} is not a number`); | ||
} | ||
if (typeof y !== 'number') { | ||
throw new TypeError(`${y} is not a number`); | ||
} | ||
exports._check(x,y); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. A space is required after ','. |
||
return x * y; | ||
}; | ||
|
||
exports.divide = (x, y) => { | ||
if (typeof x !== 'number') { | ||
throw new TypeError(`${x} is not a number`); | ||
} | ||
if (typeof y !== 'number') { | ||
throw new TypeError(`${y} is not a number`); | ||
} | ||
exports._check(x,y); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. A space is required after ','. |
||
return x / y; | ||
}; | ||
|
||
module.exports = exports; | ||
module.exports = exports; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Newline required at end of file but not found. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exports._check = (x, y) => { // Ensure there's a space after the comma
if (typeof x !== 'number') {
throw new TypeError(
${x} is not a number
);}
if (typeof y !== 'number') {
throw new TypeError(
${y} is not a number
);}
};