Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tview ux #244

Merged
merged 2 commits into from
Nov 12, 2024
Merged

Fix tview ux #244

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ba2c24
fix(tui): fix pagination
danvergara Nov 7, 2024
7179a08
fix(tui): fix table list interaction by returning the previous behavi…
danvergara Nov 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions pkg/tui/tui.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,8 @@ func (t *Tui) setupQueries() {
return event
}

t.aw.pagination.SetText(fmt.Sprintf("%4d / %4d", 1, 1))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

¿Que significa estofmt.Sprintf("%4d / %4d", 1, 1), se setea un solo elemento? No sería más sinificativo si se colocan constantes o no vale la pena?


query := t.aw.queries.GetText()

// Call the Query method from the client and populate the content page.
Expand Down Expand Up @@ -290,6 +292,8 @@ func (t *Tui) setupTablesList() error {
switch event.Key() {
case tcell.KeyCtrlL:
t.app.SetFocus(t.aw.queries)
case tcell.KeyEnter:
t.updateTableMetadataOnChange("")
}

switch event.Rune() {
Expand All @@ -306,19 +310,11 @@ func (t *Tui) setupTablesList() error {
return event
})

t.aw.tables.SetFocusFunc(func() {
t.updateTableMetadataOnChange("")
})

t.aw.tables.SetChangedFunc(func(i int, tableName string, st string, s rune) {
t.updateTableMetadataOnChange(tableName)
})

return nil
}

func (t *Tui) setupPagination() {
t.aw.pagination = tview.NewTextView().SetText("1 / 10")
t.aw.pagination = tview.NewTextView().SetText(fmt.Sprintf("%4d / %4d", 1, 1))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Porque se cambia el SetText("1 / 10")?

}

// updateTableMetadataOnChange functions updates tables' data related views on different events.
Expand Down