Add pdf #28
Merged
Add pdf #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danvergara
added
enhancement
feat(images): add pdf support to png test(images): add a test cases to validate pnf to pdf transformation feat(images): add support to convert a bmp image to a pdf feat(images): add support to convert a gif to a pdf feat(images): add support to convert a jpg to a pdf feat(images): add support to convert a tiff image to a pdf feat(images): add support to convert webp to pdf test(images): add a test function to validate images getting converted to the pdf format feat(main): add file previews for documents and images based on the mimetype of the result file style(main): rename array of templates because former name conflicts with files package feat(images): add the right image size to pdf file at the time to create the page refactor(png): add support to convert the png file to a suitable color model at the time to convert the image to a pdf format
refactor(files): refactor the document factory to accept the name of the file as an argument
refactor(main): call the new features from the main file test(images): remove mr robot image feat(pdf): set the image width height will be calculated accordingly feat(pdf): add support for the rest of the images format test(documents): add test for the rest of the images formats test(files): add test parallelism to the test packages ci(actions): remove unnecessary steps at the tests job test(pdf): remove test cases since they misbehave on CI and are not that critical docs(files): add doc comments to critical parts of the feature
…formats they can be converted to fix(pdf): remove unused func
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PDF support
Description
This Pull Request introduces the support for PDF files, the ability to convert images to PDF and vice-versa.
The server returns a zip file at the time to convert a PDF file to images.
This is pretty much the workflow of converting PDF files to images:
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
QA'd this locally and added some more tests to validate the feature.
Checklist: