Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only push image on tags and releases #30

Merged
merged 2 commits into from
Jan 26, 2024
Merged

Conversation

danvergara
Copy link
Owner

Only push image on tags and releases

Description

This PR restricts when to push the image to container registry, doing so on merge events onto the main branch could be risky for users.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@danvergara danvergara added the enhancement New feature or request label Jan 25, 2024
@danvergara danvergara self-assigned this Jan 25, 2024
@danvergara danvergara changed the title only push image on tags and releases Only push image on tags and releases Jan 25, 2024
@danvergara danvergara force-pushed the container-image-push-on-tags branch from a50882d to 41e7b4a Compare January 26, 2024 00:03
@danvergara danvergara merged commit a1a865b into main Jan 26, 2024
1 check passed
@danvergara danvergara deleted the container-image-push-on-tags branch January 26, 2024 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants