Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-16365 client: intercept MPI_Init() to avoid nested call (#14992) #15047

Merged
merged 3 commits into from
Sep 3, 2024

Conversation

wiliamhuang
Copy link
Contributor

We observed deadlock in MPI applications on Aurora due to nested calls of zeInit() inside MPI_Init(). daos_init() is involved in such nested calls. This PR intercepts MPI_Init() and avoid running daos_init() inside MPI_Init().

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

We observed deadlock in MPI applications on Aurora due to nested calls of zeInit() inside MPI_Init(). daos_init() is involved in such nested calls. This PR intercepts MPI_Init() and avoid running daos_init() inside MPI_Init().

Signed-off-by: Lei Huang <[email protected]>
@wiliamhuang wiliamhuang added clean-cherry-pick Cherry-pick from another branch that did not require additional edits approved-to-merge PR has received release branch merge approval labels Aug 30, 2024
Copy link

Ticket title is 'deadlock in MPI application on Aurora with libpil4dfs'
Status is 'Awaiting backport'
Labels: 'intercept_lib,scrubbed_2.8'
Job should run at elevated priority (1)
https://daosio.atlassian.net/browse/DAOS-16365

@github-actions github-actions bot added the priority Ticket has high priority (automatically managed) label Aug 30, 2024
@wiliamhuang wiliamhuang marked this pull request as ready for review August 30, 2024 15:02
@wiliamhuang wiliamhuang requested review from a team as code owners August 30, 2024 15:02
@wiliamhuang wiliamhuang requested review from knard38 and removed request for a team August 30, 2024 15:02
Features: pil4dfs

Signed-off-by: Lei Huang <[email protected]>
Features: pil4dfs

Signed-off-by: Lei Huang <[email protected]>
@wiliamhuang wiliamhuang requested a review from a team September 3, 2024 12:40
@wiliamhuang
Copy link
Contributor Author

All tests passed in CI.

@mchaarawi mchaarawi merged commit a0e7d52 into release/2.6 Sep 3, 2024
52 checks passed
@mchaarawi mchaarawi deleted the lei/DAOS-16365_2.6 branch September 3, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved-to-merge PR has received release branch merge approval clean-cherry-pick Cherry-pick from another branch that did not require additional edits priority Ticket has high priority (automatically managed)
Development

Successfully merging this pull request may close these issues.

3 participants