Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-16484 test: Exclude local host in default interface selection (#… #15051

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

phender
Copy link
Contributor

@phender phender commented Aug 30, 2024

…15049)

When including the local host in the default interface selection a difference in ib0 speeds will cause the logic to select eth0 and then the tcp provider.

Skip-unit-tests: true
Skip-fault-injection-test: true
Test-tag: test_setup_vm

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

…15049)

When including the local host in the default interface selection a
difference in ib0 speeds will cause the logic to select eth0 and then
the tcp provider.

Skip-unit-tests: true
Skip-fault-injection-test: true
Test-tag: test_setup_vm

Signed-off-by: Phil Henderson <[email protected]>
@phender phender requested review from a team as code owners August 30, 2024 19:46
@phender phender added the clean-cherry-pick Cherry-pick from another branch that did not require additional edits label Aug 30, 2024
Copy link

Ticket title is 'Mixed speed ib0 addapters results in eth0 being selected '
Status is 'In Progress'
Labels: 'request_for_2.6.1'
https://daosio.atlassian.net/browse/DAOS-16484

@phender phender requested a review from a team August 30, 2024 21:37
@phender phender added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Aug 30, 2024
@daltonbohning daltonbohning merged commit f4ae244 into release/2.6 Aug 30, 2024
43 checks passed
@daltonbohning daltonbohning deleted the pahender/DAOS-16484 branch August 30, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clean-cherry-pick Cherry-pick from another branch that did not require additional edits forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.
Development

Successfully merging this pull request may close these issues.

2 participants