Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-16298 test: improve get_clush_command timeout #15113

Merged
merged 3 commits into from
Sep 26, 2024
Merged

DAOS-16298 test: improve get_clush_command timeout #15113

merged 3 commits into from
Sep 26, 2024

Conversation

daltonbohning
Copy link
Contributor

Make timeout in get_clush_command per host instead of for all hosts.

Skip-unit-tests: true
Skip-fault-injection-test: true
Allow-unstable-test: true

Test-tag: soak_smoke DdbTest pr,vm

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@daltonbohning
DAOS-16298 test: improve get_clush_command timeout
6ec0535 
Make timeout in get_clush_command per host instead of for all hosts.

Skip-unit-tests: true
Skip-fault-injection-test: true
Allow-unstable-test: true

Test-tag: soak_smoke DdbTest pr,vm

Required-githooks: true

Signed-off-by: Dalton Bohning <[email protected]>
@daltonbohning daltonbohning self-assigned this Sep 10, 2024
@github-actions GitHub Actions
Copy link

Ticket title is 'ftest: improve timeout handling for get_clush_command and run_remote'
Status is 'In Progress'
https://daosio.atlassian.net/browse/DAOS-16298

@daltonbohning daltonbohning mentioned this pull request Sep 10, 2024
Closed
18 tasks
@daltonbohning daltonbohning marked this pull request as ready for review September 11, 2024 21:03
@daltonbohning daltonbohning requested review from a team as code owners September 11, 2024 21:03
shimizukko
shimizukko previously approved these changes Sep 12, 2024
View reviewed changes
phender
phender previously approved these changes Sep 17, 2024
View reviewed changes
src/tests/ftest/util/run_utils.py Outdated
Comment on lines 372 to 373
if fanout is not None:
cmd_list.extend(["-f", str(fanout)])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be simpler due to line 368?

Suggested change
if fanout is not None:
cmd_list.extend(["-f", str(fanout)])
cmd_list.extend(["-f", str(fanout)])

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

improved

@daltonbohning
simplify cmd_list
ea370f0 
Skip-unit-tests: true
Skip-fault-injection-test: true
Allow-unstable-test: true

Required-githooks: true

Signed-off-by: Dalton Bohning <[email protected]>
@daltonbohning daltonbohning dismissed stale reviews from phender and shimizukko via ea370f0 September 17, 2024 20:51
@daltonbohning
verify soak smoke
f11dcb7 
Skip-unit-tests: true
Skip-fault-injection-test: true
Allow-unstable-test: true

Test-tag: soak_smoke DdbTest pr,vm

Required-githooks: true

Signed-off-by: Dalton Bohning <[email protected]>
@daltonbohning daltonbohning requested a review from a team September 24, 2024 23:26
@daltonbohning daltonbohning added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Sep 24, 2024
@daltonbohning daltonbohning merged commit 173d862 into master Sep 26, 2024
47 checks passed
@daltonbohning daltonbohning deleted the dbohning/daos-16298-2 branch September 26, 2024 19:41
mchaarawi added a commit that referenced this pull request Oct 1, 2024
@mchaarawi
Revert "DAOS-16298 test: improve get_clush_command timeout (#15113)"
444a7e0 
Quick-Functional: true
Test-tag: test_ior_small
Test-repeat: 10

This reverts commit 173d862.
daltonbohning added a commit that referenced this pull request Oct 4, 2024
@daltonbohning
DAOS-16298 test: improve get_clush_command timeout (#15113)
870aedd 
Make timeout in get_clush_command per host instead of for all hosts.

Skip-unit-tests: true
Skip-fault-injection-test: true
Allow-unstable-test: true

Test-tag: soak_smoke DdbTest pr,vm

Required-githooks: true

Signed-off-by: Dalton Bohning <[email protected]>
daltonbohning added a commit that referenced this pull request Oct 7, 2024
@daltonbohning
DAOS-16298 test: improve get_clush_command timeout (#15113) (#15252)
c05c486 
Make timeout in get_clush_command per host instead of for all hosts.

Signed-off-by: Dalton Bohning <[email protected]>
This was referenced Oct 7, 2024
Closed
Closed
This was referenced Oct 8, 2024
Closed
Merged
@mjmac mjmac mentioned this pull request Nov 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phender phender phender approved these changes

@shimizukko shimizukko shimizukko approved these changes

@rpadma2 rpadma2 Awaiting requested review from rpadma2

Assignees

@daltonbohning daltonbohning

Labels
forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daltonbohning @shimizukko @phender