Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-16482 control: Increase min hugepages for single tgt count #15115

Merged
merged 3 commits into from
Sep 17, 2024

Conversation

tanabarr
Copy link
Contributor

@tanabarr tanabarr commented Sep 10, 2024

DMA buffer allocations may fail for single target count due to
insufficient hugepages available. Increase minimum number of hugepages
for single target count when in PMem mode.

Feature: control
Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

Test-tag: ContinuousWrite DfuseSpaceCheck CsumErrorLog SparseFile NvmeEnospace PoolCreateAllHwTests PoolCreateCapacityTests RbldNoCapacity MSMembershipTest control
Test-provider: ofi+tcp
Required-githooks: true
Signed-off-by: Tom Nabarro <[email protected]>
@tanabarr tanabarr requested review from a team as code owners September 10, 2024 22:29
Copy link

github-actions bot commented Sep 10, 2024

Ticket title is 'pool/create_all_hw.py:PoolCreateAllHwTests.test_one_pool_hw - only starting half of dual engines with single targets'
Status is 'In Review'
Labels: '2.6.1rc1,ci_2.6_daily,ci_master_daily,daily_test,tcp_provider'
https://daosio.atlassian.net/browse/DAOS-16482

@tanabarr tanabarr self-assigned this Sep 11, 2024
@tanabarr tanabarr force-pushed the tanabarr/control-dmabuf-singletgt-fix branch from 46b0597 to c80d29e Compare September 11, 2024 14:08
knard38
knard38 previously approved these changes Sep 11, 2024
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15115/4/execution/node/1444/log

kjacque
kjacque previously approved these changes Sep 12, 2024
Copy link
Contributor

@kjacque kjacque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic seems fine based on the discussion in standup. I wouldn't block on my comment below, but I do think some documentation is merited in the code in this case.

src/control/server/storage/bdev.go Outdated Show resolved Hide resolved
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15115/4/execution/node/1460/log

Test-tag: ContinuousWrite DfuseSpaceCheck CsumErrorLog SparseFile NvmeEnospace PoolCreateAllHwTests PoolCreateCapacityTests RbldNoCapacity MSMembershipTest control
Test-provider: ofi+tcp
Required-githooks: true

Signed-off-by: Tom Nabarro <[email protected]>
…abuf-singletgt-fix

Test-tag: ContinuousWrite DfuseSpaceCheck CsumErrorLog SparseFile NvmeEnospace PoolCreateAllHwTests PoolCreateCapacityTests RbldNoCapacity MSMembershipTest control
Test-provider: ofi+tcp
Signed-off-by: Tom Nabarro <[email protected]>
@tanabarr tanabarr dismissed stale reviews from kjacque and knard38 via 96393c2 September 12, 2024 22:04
@tanabarr tanabarr requested review from kjacque and knard38 September 12, 2024 22:09
@tanabarr tanabarr added bug control-plane work on the management infrastructure of the DAOS Control Plane labels Sep 12, 2024
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15115/5/execution/node/1460/log

@tanabarr
Copy link
Contributor Author

https://build.hpdd.intel.com/blue/organizations/jenkins/daos-stack%2Fdaos/detail/PR-15115/5/tests shows that the single target test variants now pass when they were failing in run no. 4.

@tanabarr
Copy link
Contributor Author

@tanabarr tanabarr added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Sep 15, 2024
@tanabarr tanabarr requested a review from a team September 17, 2024 21:30
@daltonbohning daltonbohning merged commit b801076 into master Sep 17, 2024
60 of 62 checks passed
@daltonbohning daltonbohning deleted the tanabarr/control-dmabuf-singletgt-fix branch September 17, 2024 21:34
tanabarr added a commit that referenced this pull request Oct 7, 2024
DMA buffer allocations may fail for single target count due to
insufficient hugepages available. Increase minimum number of hugepages
for single target count when in PMem mode.

Signed-off-by: Tom Nabarro <[email protected]>
daltonbohning pushed a commit that referenced this pull request Oct 8, 2024
…) (#15259)

DMA buffer allocations may fail for single target count due to
insufficient hugepages available. Increase minimum number of hugepages
for single target count when in PMem mode.

Signed-off-by: Tom Nabarro <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug control-plane work on the management infrastructure of the DAOS Control Plane forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.
Development

Successfully merging this pull request may close these issues.

6 participants