Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-16386 utils: Add DDB Feature and RM_POOL Support (#15062) #15474

Merged
merged 3 commits into from
Jan 10, 2025

Conversation

wangshilong
Copy link
Contributor

This PR enhances the DDB functionality for CR purposes with the following updates:

  1. Pool Behavior Control:

Administrators can now control certain vos pool behaviors, such as skipping vos pool loading or setting a vos pool to immutable mode.

  1. Manual Pool Shard Removal:

A new command ddb rm_pool <vos_pool> has been introduced, allowing administrators to manually remove pool shards.

  1. SPDK Environment Initialization Bug Fix:

Fixed an issue where spdk_env_init() would fail during reinitialization.

These updates aim to improve system flexibility and stability, providing administrators with more robust management capabilities.

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@wangshilong wangshilong requested review from a team as code owners November 8, 2024 04:12
@wangshilong wangshilong requested a review from Nasf-Fan November 8, 2024 04:13
Copy link

github-actions bot commented Nov 8, 2024

Ticket title is 'Enhance DDB for CR purpose'
Status is 'Awaiting backport'
Job should run at elevated priority (1)
https://daosio.atlassian.net/browse/DAOS-16386

@wangshilong wangshilong added unclean-cherry-pick Indicates that a cherry-pick had merge conflicts that needed resolving. release-2.6.2 Targeted for release 2.6.2 labels Nov 8, 2024
Wang Shilong added 2 commits November 15, 2024 21:03
This PR enhances the DDB functionality for CR purposes with
the following updates:

1. Pool Behavior Control:

Administrators can now control certain vos pool behaviors,
such as skipping vos pool loading or setting a vos pool to immutable  mode.

2. Manual Pool Shard Removal:

A new command ddb rm_pool <vos_pool> has been introduced,
allowing administrators to manually remove pool shards.

3. SPDK Environment Initialization Bug Fix:

Fixed an issue where spdk_env_init() would fail during reinitialization.

These updates aim to improve system flexibility and stability,
providing administrators with more robust management capabilities.

Required-githooks: true

Signed-off-by: Wang Shilong <[email protected]>
skip-nlt: true
Required-githooks: true

Signed-off-by: Wang Shilong <[email protected]>
@wangshilong wangshilong force-pushed the shilongw/DAOS-16386-release_2.6 branch from 5c898ea to 8b27b4c Compare November 16, 2024 02:05
@github-actions github-actions bot added the priority Ticket has high priority (automatically managed) label Jan 9, 2025
@wangshilong wangshilong requested a review from a team January 10, 2025 06:07
@wangshilong wangshilong added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Jan 10, 2025
@daltonbohning daltonbohning merged commit c74d15d into release/2.6 Jan 10, 2025
54 of 57 checks passed
@daltonbohning daltonbohning deleted the shilongw/DAOS-16386-release_2.6 branch January 10, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. priority Ticket has high priority (automatically managed) release-2.6.2 Targeted for release 2.6.2 unclean-cherry-pick Indicates that a cherry-pick had merge conflicts that needed resolving.
Development

Successfully merging this pull request may close these issues.

4 participants