Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-16881 control: Fix daos_server scm prep for single missing ns (#… #15701

Merged
merged 1 commit into from
Jan 9, 2025
Merged

DAOS-16881 control: Fix daos_server scm prep for single missing ns (#… #15701

merged 1 commit into from
Jan 9, 2025

Conversation

tanabarr
Copy link
Contributor

@tanabarr tanabarr commented Jan 8, 2025 •
edited
Loading

…15632)

When single socket is missing a pmem namespace on dual-socket host a
confusing no-space error can be returned from daos_server scm prepare.
The previously required workaround is to specify --socket. Fix this
issue by adding NumaNode in fall-back case where ndctl region idset
overflow requires matching of numa/socket via ipmctl region info
instead. Also add unit test cases to cover the situation.

Features: control

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@tanabarr
DAOS-16881 control: Fix daos_server scm prep for single missing ns (#…
fb84338 
…15632)

When single socket is missing a pmem namespace on dual-socket host a
confusing no-space error can be returned from daos_server scm prepare.
The previously required workaround is to specify --socket. Fix this
issue by adding NumaNode in fall-back case where ndctl region idset
overflow requires matching of numa/socket via ipmctl region info
instead. Also add unit test cases to cover the situation.

Signed-off-by: Tom Nabarro <[email protected]>
Features: control
@tanabarr tanabarr added control-plane work on the management infrastructure of the DAOS Control Plane unclean-cherry-pick Indicates that a cherry-pick had merge conflicts that needed resolving. labels Jan 8, 2025
@tanabarr tanabarr requested review from kjacque and knard38 January 8, 2025 10:10
@tanabarr tanabarr self-assigned this Jan 8, 2025
@tanabarr tanabarr requested review from a team as code owners January 8, 2025 10:10
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2025

Ticket title is 'Erroneous behaviour of daos_server scm scan'
Status is 'Awaiting backport'
Labels: 'PMEM'
Job should run at elevated priority (1)
https://daosio.atlassian.net/browse/DAOS-16881

@github-actions github-actions bot added the priority Ticket has high priority (automatically managed) label Jan 8, 2025
@daltonbohning daltonbohning requested a review from a team January 9, 2025 21:55
@daltonbohning daltonbohning added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Jan 9, 2025
@daltonbohning daltonbohning merged commit f76386c into release/2.6 Jan 9, 2025
61 of 62 checks passed
@daltonbohning daltonbohning deleted the tanabarr/control-ds-scm-prep-nospc-fix-rel2_6 branch January 9, 2025 21:55
@mjmac mjmac mentioned this pull request Jan 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjacque kjacque kjacque approved these changes

@knard38 knard38 Awaiting requested review from knard38

Assignees

@tanabarr tanabarr

Labels
control-plane work on the management infrastructure of the DAOS Control Plane forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. priority Ticket has high priority (automatically managed) unclean-cherry-pick Indicates that a cherry-pick had merge conflicts that needed resolving.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tanabarr @kjacque @daltonbohning