Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-6611 control: Enable dmg pool exclude,drain,reint on multiple ranks #15731

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

generate valid results from outer error, return multiple failed ranks

819ef5c
Select commit
Loading
Failed to load commit list.
Open

DAOS-6611 control: Enable dmg pool exclude,drain,reint on multiple ranks #15731

generate valid results from outer error, return multiple failed ranks
819ef5c
Select commit
Loading
Failed to load commit list.
DCO / DCO required action Feb 10, 2025 in 1s

DCO

There is one commit incorrectly signed off. This means that the author of this commit failed to include a Signed-off-by line in the commit message.

To avoid having PRs blocked in the future, always include Signed-off-by: Author Name <[email protected]> in every commit message. You can also do this automatically by using the -s flag (i.e., git commit -s).

Here is how to fix the problem so that this code can be merged.


Rebase the branch

If you have a local git environment and meet the criteria below, one option is to rebase the branch and add your Signed-off-by lines in the new commits. Please note that if others have already begun work based upon the commits in this branch, this solution will rewrite history and may cause serious issues for collaborators (described in the git documentation under "The Perils of Rebasing").

You should only do this if:

  • You are the only author of the commits in this branch
  • You are absolutely certain nobody else is doing any work based upon this branch
  • There are no empty commits in the branch (for example, a DCO Remediation Commit which was added using --allow-empty)

To add your Signed-off-by line to every commit in this branch:

  1. Ensure you have a local copy of your branch by checking out the pull request locally via command line.
  2. In your local branch, run: git rebase HEAD~8 --signoff
  3. Force push your changes to overwrite the branch: git push --force-with-lease origin tanabarr/control-drainpool-multirank

Summary

Commit sha: 819ef5c, Author: Tom Nabarro, Committer: Tom Nabarro; Expected "Tom Nabarro [email protected]", but got "Tom Nabarro [email protected]".