Adding producer and consumer app examples for Spring Boot integration #1208

salaboy · 2025-02-04T10:08:37Z

Description

This PR adds two Spring Boot application examples as part of a new directory called spring-boot-examples to differentiate from the plain Java examples provided in this repo.
This tests uses Testcontainers and the dapr-spring modules.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1207

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

Code compiles correctly
Created/updated tests
Extended the documentation

salaboy · 2025-02-04T10:14:24Z

@artur-ciocanu @artursouza @cicoyle recommendations are more than welcome on these examples.. I will add a README.md to this, but I appreciate code reviews and suggestions to get this merged ASAP

salaboy · 2025-02-05T11:33:37Z

This PR depends on: #1192 for the actor runtime connections

spring-boot-examples/consumer-app/src/main/java/io/dapr/springboot/examples/consumer/Order.java

...onsumer-app/src/main/java/io/dapr/springboot/examples/consumer/SubscriberRestController.java

artursouza · 2025-02-06T18:15:52Z

spring-boot-examples/pom.xml

+    <parent>
+        <groupId>io.dapr</groupId>
+        <artifactId>dapr-sdk-parent</artifactId>
+        <version>1.14.0-SNAPSHOT</version>


Update the release script to update any new pom files. This is the disadvantage of creating a new project.

@artursouza I've updated only the update sdk script.. do I need to update somewhere else?

spring-boot-examples/new-customer.json

spring-boot-examples/README.md

azure-pipelines · 2025-02-11T04:13:11Z

There was an error handling pipeline event f3c3e364-6449-4327-8949-b4bcc2287e1c.

azure-pipelines · 2025-02-11T04:13:16Z

There was an error handling pipeline event e2ad4049-1f9c-43b5-9730-d9968016868d.

azure-pipelines · 2025-02-11T04:13:23Z

There was an error handling pipeline event bfb343e8-cca5-46c1-932c-b2d0a739308e.

salaboy · 2025-02-11T06:48:02Z

@artursouza I've updated the tutorial to use a local registry, so we don't need to create container images and push containers to the dapr registry.

salaboy · 2025-02-12T02:44:25Z

@artursouza this is ready for reviewing and merging.. I am not sure if there are more things to update on the release scripts.. can you please check?
Now there is a flaky test completely unrelated to this code.

artur-ciocanu

@salaboy great job! I have left comments, but those are mostly about formatting, I think it makes sense to add Checkstyle and fix all the issues. The POM files are also weirdly formatted, ideally it should use the same convention as in the other modules.

My biggest concern/question is around usage of DockerClient, to be honest I am not sure why it was required and if there is a way to have a simpler setup.

spring-boot-examples/consumer-app/src/test/resources/application.properties

spring-boot-examples/kubernetes/consumer-app.yaml

spring-boot-examples/kubernetes/kvbinding.yaml

spring-boot-examples/kubernetes/kvstore.yaml

spring-boot-examples/kubernetes/producer-app.yaml

...roducer-app/src/test/java/io/dapr/springboot/examples/producer/DaprTestContainersConfig.java

artur-ciocanu · 2025-02-12T21:49:17Z

...roducer-app/src/test/java/io/dapr/springboot/examples/producer/DaprTestContainersConfig.java

+
+
+   @Bean
+   public RabbitMQContainer rabbitMQContainer(Network daprNetwork){


Formatting is off

artur-ciocanu · 2025-02-12T21:49:23Z

...roducer-app/src/test/java/io/dapr/springboot/examples/producer/DaprTestContainersConfig.java

+   }
+
+   @Bean
+   public  PostgreSQLContainer<?> postgreSQLContainer(Network daprNetwork){


Formatting is off

artur-ciocanu · 2025-02-12T21:49:30Z

...roducer-app/src/test/java/io/dapr/springboot/examples/producer/DaprTestContainersConfig.java

+     rabbitMqProperties.put("user", "guest");
+     rabbitMqProperties.put("password", "guest");
+
+     return new DaprContainer("daprio/daprd:1.14.4")


Formatting is off

...producer-app/src/test/java/io/dapr/springboot/examples/producer/TestProducerApplication.java

salaboy · 2025-02-13T02:08:28Z

@artur-ciocanu ok.. the formatting is getting better.. this is one of the reasons to change to IntelliJ Enterprise @artursouza :)

salaboy · 2025-02-13T02:09:07Z

@artur-ciocanu look at the nice trick for reuse that @eddumelendez suggested.. now I've updated the readme and the code to pick up an SB app arg to check in which mode we are running :)

Signed-off-by: salaboy <[email protected]>

…rs module (dapr#1210) * feat: Adding basic HTTPEndpoint configuration support in testcontainers module Signed-off-by: Laurent Broudoux <[email protected]> * feat: dapr#1209 Adding test for HTTPEndpoint in testcontainers module Signed-off-by: Laurent Broudoux <[email protected]> --------- Signed-off-by: Laurent Broudoux <[email protected]> Signed-off-by: salaboy <[email protected]>

Signed-off-by: salaboy <[email protected]>

* Add app health check support to Dapr Testcontainer Signed-off-by: Artur Ciocanu <[email protected]> * Some minor cleanup Signed-off-by: Artur Ciocanu <[email protected]> * Move waiting to beforeEach, it looks more natural Signed-off-by: Artur Ciocanu <[email protected]> --------- Signed-off-by: Artur Ciocanu <[email protected]> Co-authored-by: Artur Ciocanu <[email protected]> Signed-off-by: salaboy <[email protected]>

Signed-off-by: salaboy <[email protected]>

…ainers Signed-off-by: salaboy <[email protected]>

Signed-off-by: salaboy <[email protected]>

…vide steps to create containers with spring boot Signed-off-by: salaboy <[email protected]>

Signed-off-by: salaboy <[email protected]>

salaboy requested review from a team as code owners February 4, 2025 10:08

salaboy force-pushed the 1207-sb-examples branch from c7a933a to 100d037 Compare February 4, 2025 10:13

salaboy force-pushed the 1207-sb-examples branch from 265c708 to 695b93e Compare February 4, 2025 12:50

salaboy mentioned this pull request Feb 5, 2025

Add actor testcontainer tests #1192

Open

salaboy force-pushed the 1207-sb-examples branch 2 times, most recently from 42a423d to abbdf7c Compare February 6, 2025 09:33

artursouza reviewed Feb 6, 2025

View reviewed changes

spring-boot-examples/consumer-app/src/main/java/io/dapr/springboot/examples/consumer/Order.java Show resolved Hide resolved

artursouza reviewed Feb 6, 2025

View reviewed changes

...onsumer-app/src/main/java/io/dapr/springboot/examples/consumer/SubscriberRestController.java Outdated Show resolved Hide resolved

artursouza reviewed Feb 6, 2025

View reviewed changes

spring-boot-examples/new-customer.json Outdated Show resolved Hide resolved

artursouza reviewed Feb 6, 2025

View reviewed changes

spring-boot-examples/README.md Show resolved Hide resolved

salaboy force-pushed the 1207-sb-examples branch 7 times, most recently from 2c47a2b to c52312a Compare February 11, 2025 04:13

salaboy force-pushed the 1207-sb-examples branch from cbb58f3 to 555fa34 Compare February 11, 2025 06:47

salaboy requested a review from artursouza February 11, 2025 06:48

artur-ciocanu previously approved these changes Feb 12, 2025

View reviewed changes

salaboy dismissed artur-ciocanu’s stale review via a06fd49 February 13, 2025 01:31

salaboy and others added 26 commits February 13, 2025 16:47

adding spring boot producer

a33cfe8

Signed-off-by: salaboy <[email protected]>

adding consumer app

639f7d3

Signed-off-by: salaboy <[email protected]>

increasing wait for events to popup

dcc5811

Signed-off-by: salaboy <[email protected]>

adding readme and examples

546593e

Signed-off-by: salaboy <[email protected]>

aligning tests for examples

c97999e

Signed-off-by: salaboy <[email protected]>

increasing time out

89ec5ef

Signed-off-by: salaboy <[email protected]>

adding health check from the sidecar

d1c42b6

Signed-off-by: salaboy <[email protected]>

updating example

276e03b

Signed-off-by: salaboy <[email protected]>

fixing example

b0ec018

Signed-off-by: salaboy <[email protected]>

commenting reuse

4ffeaec

Signed-off-by: salaboy <[email protected]>

adding how to run on Kubernetes, unfortunately we need to create cont…

3508f72

…ainers Signed-off-by: salaboy <[email protected]>

removing subscription and fixing scopes

89b28d3

Signed-off-by: salaboy <[email protected]>

adding license headers and logger

f2c9e21

Signed-off-by: salaboy <[email protected]>

updating logs

51fdaec

Signed-off-by: salaboy <[email protected]>

updating READMEs and update_sdk_version for new module

a0d21cb

Signed-off-by: salaboy <[email protected]>

removing old line

9bd3d22

Signed-off-by: salaboy <[email protected]>

removing sleeps, using Wait

1fa6c0d

Signed-off-by: salaboy <[email protected]>

updating Kubernetes tutorial to use local registry with KIND, and pro…

892a4c7

…vide steps to create containers with spring boot Signed-off-by: salaboy <[email protected]>

adding new lines and formatting

013937d

Signed-off-by: salaboy <[email protected]>

updating reuse and removing comments

00807fb

Signed-off-by: salaboy <[email protected]>

fixing reuse

6d62144

Signed-off-by: salaboy <[email protected]>

removing line break

54b0068

Signed-off-by: salaboy <[email protected]>

fixing custom line breaks

bb37fed

Signed-off-by: salaboy <[email protected]>

fixing xml indent to 2 spaces

ad77a1f

Signed-off-by: salaboy <[email protected]>

salaboy force-pushed the 1207-sb-examples branch from 04cb659 to ad77a1f Compare February 13, 2025 07:47

Merge branch 'master' into 1207-sb-examples

d08c87c

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding producer and consumer app examples for Spring Boot integration #1208

Adding producer and consumer app examples for Spring Boot integration #1208

salaboy commented Feb 4, 2025

salaboy commented Feb 4, 2025

salaboy commented Feb 5, 2025

artursouza Feb 6, 2025

salaboy Feb 11, 2025

azure-pipelines bot commented Feb 11, 2025

azure-pipelines bot commented Feb 11, 2025

azure-pipelines bot commented Feb 11, 2025

salaboy commented Feb 11, 2025

salaboy commented Feb 12, 2025

artur-ciocanu left a comment

artur-ciocanu Feb 12, 2025

artur-ciocanu Feb 12, 2025

artur-ciocanu Feb 12, 2025

salaboy commented Feb 13, 2025

salaboy commented Feb 13, 2025



		@Bean
		public RabbitMQContainer rabbitMQContainer(Network daprNetwork){

Adding producer and consumer app examples for Spring Boot integration #1208

Are you sure you want to change the base?

Adding producer and consumer app examples for Spring Boot integration #1208

Conversation

salaboy commented Feb 4, 2025

Description

Issue reference

Checklist

salaboy commented Feb 4, 2025

salaboy commented Feb 5, 2025

artursouza Feb 6, 2025

Choose a reason for hiding this comment

salaboy Feb 11, 2025

Choose a reason for hiding this comment

azure-pipelines bot commented Feb 11, 2025

azure-pipelines bot commented Feb 11, 2025

azure-pipelines bot commented Feb 11, 2025

salaboy commented Feb 11, 2025

salaboy commented Feb 12, 2025

artur-ciocanu left a comment

Choose a reason for hiding this comment

artur-ciocanu Feb 12, 2025

Choose a reason for hiding this comment

artur-ciocanu Feb 12, 2025

Choose a reason for hiding this comment

artur-ciocanu Feb 12, 2025

Choose a reason for hiding this comment

salaboy commented Feb 13, 2025

salaboy commented Feb 13, 2025