Skip to content

Commit

Permalink
updating config API to use v1 endpoint (#496)
Browse files Browse the repository at this point in the history
* updating config API to use v1 endpoint

Signed-off-by: Shivam Kumar <[email protected]>

* using latest runtime rc

Signed-off-by: Shivam Kumar <[email protected]>

---------

Signed-off-by: Shivam Kumar <[email protected]>
  • Loading branch information
shivamkm07 authored May 30, 2023
1 parent b1fb0c2 commit 1114591
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/test-e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
env:
GOVER: 1.19
DAPR_CLI_VER: 1.10.0
DAPR_RUNTIME_VER: 1.10.0
DAPR_RUNTIME_VER: 1.11.0-rc.5
DAPR_INSTALL_URL: https://raw.githubusercontent.com/dapr/cli/master/install/install.sh
DAPR_CLI_REF: ""
DAPR_REF: ""
Expand Down
6 changes: 3 additions & 3 deletions src/implementation/Client/GRPCClient/configuration.ts
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ export default class GRPCClientConfiguration implements IClientConfiguration {
const client = await this.client.getClient();

return new Promise((resolve, reject) => {
client.getConfigurationAlpha1(msg, metadata, (err, res: GetConfigurationResponse) => {
client.getConfiguration(msg, metadata, (err, res: GetConfigurationResponse) => {
if (err) {
return reject(err);
}
Expand Down Expand Up @@ -122,7 +122,7 @@ export default class GRPCClientConfiguration implements IClientConfiguration {
// and will stay open as long as the client is open
// we will thus create a set with our listeners so we don't
// break on multi listeners
const stream = client.subscribeConfigurationAlpha1(msg, metadata);
const stream = client.subscribeConfiguration(msg, metadata);
let streamId: string;

stream.on("data", async (data: SubscribeConfigurationResponse) => {
Expand All @@ -149,7 +149,7 @@ export default class GRPCClientConfiguration implements IClientConfiguration {
req.setStoreName(storeName);
req.setId(streamId);

client.unsubscribeConfigurationAlpha1(req, (err, res: UnsubscribeConfigurationResponse) => {
client.unsubscribeConfiguration(req, (err, res: UnsubscribeConfigurationResponse) => {
if (err || !res.getOk()) {
return reject(res.getMessage());
}
Expand Down

0 comments on commit 1114591

Please sign in to comment.