Skip to content

Commit

Permalink
Fixed build for apps using Dagger (regression) (#794)
Browse files Browse the repository at this point in the history
  • Loading branch information
dariuszseweryn authored Jun 14, 2022
1 parent 7da7ca9 commit d72038c
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 16 deletions.
7 changes: 7 additions & 0 deletions dagger-library-shadow/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,13 @@ artifacts {
archives shadowJar
}

shadowJar {
// Dagger 2.25.4 introduced a file for tracking purposes. This can break apps using Dagger.
// See https://github.com/dariuszseweryn/RxAndroidBle/issues/789
// Source https://github.com/google/dagger/commit/709098caaf4c7124f5e5313c1aa9ab34fced0031
exclude('META-INF/com.google.dagger_dagger.version')
}

dependencies {
implementation rootProject.ext.libs.dagger
}
Expand Down
2 changes: 1 addition & 1 deletion gradle.properties
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
GROUP=com.polidea.rxandroidble2
VERSION_NAME=1.15.0
VERSION_NAME=1.15.1-SNAPSHOT

POM_DESCRIPTION=RxJava backed support for Bluetooth Low Energy in Android

Expand Down
7 changes: 0 additions & 7 deletions rxandroidble/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -42,13 +42,6 @@ android {
}

preBuild.dependsOn 'checkstyle'

packagingOptions {
// Dagger 2.25.4 introduced a file for tracking purposes. This can break apps using Dagger.
// See https://github.com/dariuszseweryn/RxAndroidBle/issues/789
// Source https://github.com/google/dagger/commit/709098caaf4c7124f5e5313c1aa9ab34fced0031
excludes = ['**/com.google.dagger_dagger.version']
}
}

androidGroovy {
Expand Down
9 changes: 1 addition & 8 deletions rxandroidble3/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -41,14 +41,7 @@ android {
abortOnError false
}

// preBuild.dependsOn 'checkstyle'

packagingOptions {
// Dagger 2.25.4 introduced a file for tracking purposes. This can break apps using Dagger.
// See https://github.com/dariuszseweryn/RxAndroidBle/issues/789
// Source https://github.com/google/dagger/commit/709098caaf4c7124f5e5313c1aa9ab34fced0031
excludes = ['**/com.google.dagger_dagger.version']
}
preBuild.dependsOn 'checkstyle'
}

apply from: rootProject.file('gradle/src-gen-rxjava3-from-rxjava2.gradle')
Expand Down

0 comments on commit d72038c

Please sign in to comment.