Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support OFF log level #139

Merged
merged 1 commit into from
Feb 12, 2024
Merged

support OFF log level #139

merged 1 commit into from
Feb 12, 2024

Conversation

pawelru
Copy link
Contributor

@pawelru pawelru commented Feb 12, 2024

closes #138

Copy link

codecov bot commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9947980) 83.95% compared to head (2623362) 83.95%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #139   +/-   ##
=======================================
  Coverage   83.95%   83.95%           
=======================================
  Files          10       10           
  Lines         561      561           
=======================================
  Hits          471      471           
  Misses         90       90           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@daroczig
Copy link
Owner

nice, thanks 🙇

@daroczig daroczig merged commit ec619ce into daroczig:master Feb 12, 2024
4 checks passed
@m7pr
Copy link
Contributor

m7pr commented Feb 29, 2024

@daroczig can we get a CRAN release to get this feature accessible via install.packages('logger')?

@daroczig
Copy link
Owner

daroczig commented Feb 29, 2024

yeah, thanks for the bump -- will do by the end of this week 👍
you can track progress at #144

@m7pr
Copy link
Contributor

m7pr commented Feb 29, 2024

Thanks @daroczig ! You are the true legend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request] new OFF log level to disable logger
3 participants