Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #51
I tried to match the format that you used for the other appenders, but may not have done it quite right. In particular, I know that my
httr::POST
call will return aresponse
object. I'm not sure whether it's within scope to handle cases where theresponse
object reports a failure of some sort. There are rate limits involved, so I'm not sure if the best approach would be to handle that in the appender, or to trust the user to handle that in one way or another.I'm not sure if it would be best to limit the
webhook_url
so that it must match the format teams uses. One the one hand, by not restricting it there's no chance that it will be incompatible with future formats (or current formats I'm not aware of). On the other hand, that makes this really more likeappender_http_post
.