Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid the PackageGraph.objectClass field. #3951

Merged
merged 2 commits into from
Dec 30, 2024

Conversation

srawlins
Copy link
Member

@srawlins srawlins commented Dec 19, 2024

Avoid the PackageGraph.objectClass field. There are sometimes LateInitializationErrors accessing it. It turns out it is not needed.

Fixes #3947


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@srawlins srawlins marked this pull request as draft December 19, 2024 18:57
@srawlins srawlins changed the title Pre-compute the ModelElement for Object. Avoid the PackageGraph.objectClass field. Dec 30, 2024
@srawlins srawlins marked this pull request as ready for review December 30, 2024 17:48
@srawlins
Copy link
Member Author

CC @dart-lang/analyzer-team

@srawlins srawlins merged commit 51256a3 into dart-lang:main Dec 30, 2024
7 checks passed
@srawlins srawlins deleted the pre-compute-object branch December 30, 2024 20:08
nex3 added a commit to sass/dart-sass that referenced this pull request Dec 30, 2024
The bug we were working around has been fixed in dart-lang/dartdoc#3951.
nex3 added a commit to sass/dart-sass that referenced this pull request Dec 30, 2024
The bug we were working around has been fixed in dart-lang/dartdoc#3951.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LateInitializationError: Field 'objectClass' has not been initialized.
2 participants