Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup leak_tracker. #195

Merged
merged 4 commits into from
Dec 17, 2023
Merged

Cleanup leak_tracker. #195

merged 4 commits into from
Dec 17, 2023

Conversation

polina-c
Copy link
Contributor

@polina-c polina-c commented Dec 15, 2023 •
edited
Loading

  1. Remove memory usage feature from leak tracker, as it is moved to memory_usage.
  2. Remove unused fields from LeakTesting.

@polina-c polina-c requested a review from CoderDake as a code owner December 15, 2023 23:33
kenzieschmoll
kenzieschmoll approved these changes Dec 16, 2023
View reviewed changes
Copy link

@kenzieschmoll kenzieschmoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two requests, but lgtm otherwise

@polina-c polina-c merged commit 8393a23 into dart-lang:main Dec 17, 2023
3 checks passed
@polina-c polina-c deleted the cleanup branch December 17, 2023 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenzieschmoll kenzieschmoll kenzieschmoll approved these changes

@CoderDake CoderDake Awaiting requested review from CoderDake

Assignees
No one assigned
Labels
package:leak_tracker_flutter_testing package:leak_tracker_testing package:leak_tracker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@polina-c @kenzieschmoll