Remove extra whitespace when parsing search inputs. (#8466)

dart-lang · Jan 16, 2025 · f43044b · f43044b
1 parent 127f6fc
commit f43044b
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,7 @@ AppEngine version, listed here to ease deployment and troubleshooting.
 ## Next Release (replace with git tag when deployed)
  * Bump runtimeVersion to `2025.01.15`.
  * Note: started deleting `Package.isBlocked`, `Publisher.isBlocked`, `User.isBlocked`.
+ * Note: Updates search form normalization: whitespaces.
 
 ## `20250114t095800-all`
  * Bump runtimeVersion to `2025.01.14`.

diff --git a/pkg/_pub_shared/lib/search/search_form.dart b/pkg/_pub_shared/lib/search/search_form.dart
@@ -367,7 +367,7 @@ class SearchForm {
   }) {
     currentPage ??= 1;
     pageSize ??= resultsPerPage;
-    final q = _stringToNull(query?.trim());
+    final q = _stringToNull(query?.replaceAll(_whitespacesRegExp, ' ').trim());
     return SearchForm._(
       query: q,
       order: order,

diff --git a/pkg/_pub_shared/test/search/search_form_test.dart b/pkg/_pub_shared/test/search/search_form_test.dart
@@ -30,6 +30,11 @@ void main() {
       expect(form.toSearchLink(page: 3), '/packages?q=web+framework&page=3');
     });
 
+    test('query with extra whitespaces', () {
+      final form = SearchForm(query: '   aa     bbb      cc     ');
+      expect(form.query, 'aa bbb cc');
+    });
+
     test('query with sdk context', () {
       final form = SearchForm(query: 'sdk:flutter some framework');
       expect(form.toSearchLink(), '/packages?q=sdk%3Aflutter+some+framework');