Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use highlightjs's dark theme. #7922

Merged
merged 2 commits into from
Aug 12, 2024
Merged

Use highlightjs's dark theme. #7922

merged 2 commits into from
Aug 12, 2024

Conversation

isoos
Copy link
Collaborator

@isoos isoos commented Aug 9, 2024

  • Cleanup tasks after dark mode gets stable. #7868
  • Uses scss's @import directive inside a class-based locator to scope the two files differently. scss is encouraging its users to migrate from @import to @use, but this use-case is not supported by @use.
  • Also refactored some style overrides so that the rules become more specific.

@isoos isoos requested review from jonasfj and sigurdm August 9, 2024 12:19
@isoos isoos merged commit 91abd66 into dart-lang:master Aug 12, 2024
32 checks passed
@isoos isoos deleted the dark-highlight branch August 12, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants