New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fallback to non-verified URLs only when a package analysis was not completed. #8458

Merged

isoos merged 1 commit into dart-lang:master from isoos:urls

Jan 13, 2025

Collaborator

isoos commented Jan 13, 2025

The previous logic mixed the display of (pana-)verified and non-verified (inferred-only) URLs.
The new logic will always prefer analysis content if it is available.
If the repository verification tests failed, we don't display any of the URLs (assuming the package is non-updated clone).
Non-verified URLs will be displayed only on when the package analysis has not been completed.

Note: the URLs in question are displayed in the infobox.

isoos requested a review from sigurdm

January 13, 2025 13:59

sigurdm approved these changes

View reviewed changes


          Fallback to non-verified URLs only when a package analysis was not co…

bd61bb8

…mpleted.

isoos merged commit c1a5322 into dart-lang:master

32 checks passed

isoos deleted the urls branch

January 13, 2025 14:12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet