-
Notifications
You must be signed in to change notification settings - Fork 708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
typo #6322
typo #6322
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening the PR!
However, before we can review (or land) your PR, you'll need to sign the CLA as outlined in the earlier bot comment. If you have any issues doing so though, please let us know. Thanks again!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @Tox46!
@Tox46 Just checking again if you saw the comment above. You'll have to sign the CLA for us to merge this. We'll give you another week or so but then have to close it and fix the typo ourselves. Thanks! |
This really shouldn't have taken this long and i'm sorry for that, i was investigating on a related (?) issue, as it seems to me that the flag in question has no effect whether with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again @Tox46 for fixing this!
And sorry about the extra work relating to the CLA.
Thanks for your contribution! Please replace this text with a description of what this PR is changing or adding and why, list any relevant issues, and review the contribution guidelines below.
Fixes
Contribution guidelines:
dart format
.<?code-excerpt
need to be updated in their source.dart
file as well.