Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[markdown] use build_runner to build js & wasm #1969

Merged
merged 2 commits into from
Jan 15, 2025
Merged

Conversation

kevmoo
Copy link
Member

@kevmoo kevmoo commented Jan 15, 2025

No description provided.

@kevmoo kevmoo requested a review from devoncarew January 15, 2025 19:44
@github-actions github-actions bot added type-infra A repository infrastructure change or enhancement package:markdown labels Jan 15, 2025
@kevmoo kevmoo mentioned this pull request Jan 15, 2025
1 task
Copy link

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
markdown None 7.3.0 7.3.1-wip 7.3.0 ✔️
Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ✔️
File Coverage

This check for test coverage is informational (issues shown here will not fail the PR).

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/bazel_worker/benchmark/benchmark.dart
pkgs/bazel_worker/example/client.dart
pkgs/bazel_worker/example/worker.dart
pkgs/benchmark_harness/integration_test/perf_benchmark_test.dart
pkgs/boolean_selector/example/example.dart
pkgs/clock/lib/clock.dart
pkgs/clock/lib/src/clock.dart
pkgs/clock/lib/src/default.dart
pkgs/clock/lib/src/stopwatch.dart
pkgs/clock/lib/src/utils.dart
pkgs/clock/test/clock_test.dart
pkgs/clock/test/default_test.dart
pkgs/clock/test/stopwatch_test.dart
pkgs/clock/test/utils.dart
pkgs/html/example/main.dart
pkgs/html/lib/dom.dart
pkgs/html/lib/dom_parsing.dart
pkgs/html/lib/html_escape.dart
pkgs/html/lib/parser.dart
pkgs/html/lib/src/constants.dart
pkgs/html/lib/src/encoding_parser.dart
pkgs/html/lib/src/html_input_stream.dart
pkgs/html/lib/src/list_proxy.dart
pkgs/html/lib/src/query_selector.dart
pkgs/html/lib/src/token.dart
pkgs/html/lib/src/tokenizer.dart
pkgs/html/lib/src/treebuilder.dart
pkgs/html/lib/src/utils.dart
pkgs/html/test/dom_test.dart
pkgs/html/test/parser_feature_test.dart
pkgs/html/test/parser_test.dart
pkgs/html/test/query_selector_test.dart
pkgs/html/test/selectors/level1_baseline_test.dart
pkgs/html/test/selectors/level1_lib.dart
pkgs/html/test/selectors/selectors.dart
pkgs/html/test/support.dart
pkgs/html/test/tokenizer_test.dart
pkgs/pubspec_parse/test/git_uri_test.dart
pkgs/stack_trace/example/example.dart
pkgs/watcher/test/custom_watcher_factory_test.dart
pkgs/yaml_edit/example/example.dart

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12795833535

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.114%

Totals Coverage Status
Change from base Build 12794694884: 0.0%
Covered Lines: 1558
Relevant Lines: 1621

💛 - Coveralls

Copy link
Member

@devoncarew devoncarew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little torn on requiring build_runner (but looking now, do see that we already have a pubspec dev dependeny on it).

.github/workflows/deploy_pages.yaml Outdated Show resolved Hide resolved
.github/workflows/deploy_pages.yaml Show resolved Hide resolved
.github/workflows/deploy_pages.yaml Show resolved Hide resolved
.github/workflows/deploy_pages.yaml Outdated Show resolved Hide resolved
.github/workflows/deploy_pages.yaml Show resolved Hide resolved
@kevmoo
Copy link
Member Author

kevmoo commented Jan 15, 2025

I'm a little torn on requiring build_runner (but looking now, do see that we already have a pubspec dev dependeny on it).

build_runner is THE way to do this. We don't encourage folks to call the JS compilers directly.

@kevmoo kevmoo force-pushed the fix_deploy_markdown branch from 1be9f01 to 1c270b2 Compare January 15, 2025 20:12
@kevmoo
Copy link
Member Author

kevmoo commented Jan 15, 2025

@devoncarew – PTAL

Copy link
Member

@devoncarew devoncarew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 lgtm

@kevmoo kevmoo merged commit 6e74c97 into main Jan 15, 2025
17 checks passed
@kevmoo kevmoo deleted the fix_deploy_markdown branch January 15, 2025 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:markdown type-infra A repository infrastructure change or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants