Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reduce logging #248

Merged

Conversation

HashEngineering
Copy link
Collaborator

Issue being fixed or feature implemented

Logging is reduced by marking some as "coinjoin-extra" which allows the client to ignore them and also by shortening some items such as proTxHashes to 16 characters (instead of 64).

What was done?

How Has This Been Tested?

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 55.55556% with 40 lines in your changes are missing coverage. Please review.

Project coverage is 48.56%. Comparing base (9c66d59) to head (babee12).

Files Patch % Lines
...a/org/bitcoinj/coinjoin/CoinJoinClientSession.java 63.15% 14 Missing ⚠️
...in/java/org/bitcoinj/wallet/CoinJoinExtension.java 36.36% 7 Missing ⚠️
.../bitcoinj/coinjoin/CoinJoinClientQueueManager.java 28.57% 5 Missing ⚠️
...a/org/bitcoinj/coinjoin/utils/MasternodeGroup.java 55.55% 4 Missing ⚠️
...a/org/bitcoinj/coinjoin/CoinJoinClientManager.java 25.00% 3 Missing ⚠️
...re/src/main/java/org/bitcoinj/wallet/WalletEx.java 66.66% 3 Missing ⚠️
.../src/main/java/org/bitcoinj/coinjoin/CoinJoin.java 50.00% 1 Missing ⚠️
...ava/org/bitcoinj/coinjoin/CoinJoinBaseManager.java 0.00% 1 Missing ⚠️
...main/java/org/bitcoinj/coinjoin/CoinJoinQueue.java 50.00% 1 Missing ⚠️
.../org/bitcoinj/coinjoin/utils/KeyHolderStorage.java 66.66% 1 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                   @@
##             feature-coinjoin     #248      +/-   ##
======================================================
- Coverage               48.57%   48.56%   -0.01%     
+ Complexity               7472     7469       -3     
======================================================
  Files                     451      451              
  Lines                   50205    50214       +9     
  Branches                 7133     7134       +1     
======================================================
+ Hits                    24386    24387       +1     
- Misses                  23071    23082      +11     
+ Partials                 2748     2745       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Syn-McJ Syn-McJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@HashEngineering HashEngineering merged commit 4606d5f into feature-coinjoin Mar 19, 2024
5 of 6 checks passed
@HashEngineering HashEngineering deleted the feature-coinjoin-logging-improvements branch April 30, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants