chore(p2p): remove unneeded stopMtx from MConnection

internal/consensus/block_executor.go

@@ -65,7 +65,7 @@ func (c *blockExecutor) ensureProcess(ctx context.Context, rs *cstypes.RoundStat
 	block := rs.ProposalBlock
 	crs := rs.CurrentRoundState
 	if crs.Params.Source != sm.ProcessProposalSource || !crs.MatchesBlock(block.Header, round) {
-		c.logger.Debug("CurrentRoundState is outdated, executing ProcessProposal", "crs", crs)
+		c.logger.Trace("CurrentRoundState is outdated, executing ProcessProposal", "crs", crs)
 		uncommittedState, err := c.blockExec.ProcessProposal(ctx, block, round, c.committedState, true)
 		if err != nil {
 			return fmt.Errorf("ProcessProposal abci method: %w", err)

internal/p2p/conn/connection.go

@@ -101,9 +101,6 @@ type MConnection struct {
 	// Closing quitRecvRouting will cause the recvRouting to eventually quit.
 	quitRecvRoutine chan struct{}
 
-	// used to ensure FlushStop and OnStop
-	// are safe to call concurrently.
-	stopMtx    sync.Mutex
 	stopSignal <-chan struct{}
 
 	cancel context.CancelFunc
@@ -232,11 +229,8 @@ func (c *MConnection) getLastMessageAt() time.Time {
 
 // stopServices stops the BaseService and timers and closes the quitSendRoutine.
 // if the quitSendRoutine was already closed, it returns true, otherwise it returns false.
-// It uses the stopMtx to ensure only one of FlushStop and OnStop can do this at a time.
+// It doesn't lock, as we rely on the caller (eg. BaseService) locking
 func (c *MConnection) stopServices() (alreadyStopped bool) {
-	c.stopMtx.Lock()
-	defer c.stopMtx.Unlock()
-
 	select {
 	case <-c.quitSendRoutine:
 		// already quit

internal/p2p/peermanager.go

@@ -980,6 +980,7 @@ func (m *PeerManager) Disconnected(ctx context.Context, peerID types.NodeID) {
 	}
 
 	m.dialWaker.Wake()
+	m.logger.Debug("peer disconnected", "peer", peerID, "ready", ready)
 }
 
 // Errored reports a peer error, causing the peer to be evicted if it's