Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block fusion for barrier tasks #8944

Merged
merged 2 commits into from
Nov 20, 2024
Merged

Block fusion for barrier tasks #8944

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b14f4a
Block fusion for barrier tasks
phofl Nov 20, 2024
0f2f156
Migrate to property
phofl Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions distributed/shuffle/_core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -584,6 +584,7 @@ def p2p_barrier(id: ShuffleId, *run_ids: int) -> int:

class P2PBarrierTask(Task):
spec: ShuffleSpec
block_fusion: bool
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would require hasattr in the fusion code, wouldn't it? I like the idea with the property on the baseclass better

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I defined it over in dask/dask on every class (but that's ugly in a different way)...


__slots__ = tuple(__annotations__)

Expand All @@ -598,6 +599,7 @@ def __init__(
):
self.spec = spec
super().__init__(key, func, *args, **kwargs)
self.block_fusion = True

def __repr__(self) -> str:
return f"P2PBarrierTask({self.key!r})"
Loading