Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Ex6.Rmd #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update Ex6.Rmd #16

wants to merge 1 commit into from

Conversation

jutglar
Copy link
Contributor

@jutglar jutglar commented Jan 24, 2020

updated the classification

updated the classification
@modche modche requested a review from ld162 January 24, 2020 12:00
@ld162
Copy link
Contributor

ld162 commented Jan 24, 2020

Hey @jutglar ,
we did upload a version with a continous scale yesterday to the master branch. If you want to replace it with yours please fix the warnings @zoeschindler pointed out before. I personally think it isn't necessary to change anything. Have a nice weekend :)

@toensing toensing self-requested a review January 24, 2020 17:08
@toensing
Copy link
Contributor

With the new classification the maps are more congruent and meaningful. Thank you Karuna.

Copy link
Contributor

@toensing toensing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer the new version, because in the old version negative temperature are red and positive green, which is contraituitive. Furthermore with the classes it is more accurate.

Copy link
Contributor

@zoeschindler zoeschindler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the code and it runs. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants