Change: refine the RaftEntry trait
#1293
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drmingdrmer
force-pushed
the
183-log-id
branch
3 times, most recently
from
dff2728 to
764ba69
Compare
drmingdrmer
force-pushed
the
183-log-id
branch
2 times, most recently
from
2abaffb to
25b71e0
Compare
- The `RaftEntry` trait now requires `AsRef<LogIdOf<C>>` and `AsMut<LogIdOf<C>>`, providing a more standard API for accessing the log ID of a log entry. As a result, the `RaftEntry: RaftLogId` requirement is no longer needed. - A new method, `new_normal()`, has been added to the `RaftEntry` trait to replace the `FromAppData` trait. - Additional utility methods for working with entries are now provided in the `RaftEntryExt` trait. - Part of databendlabs#1278 Upgrade tips: 1. **For applications using a custom `RaftEntry` implementation** (e.g., declared with `declare_raft_types!(MyTypes: Entry = MyEntry)`): - Update the `RaftEntry` implementation for your custom entry type (`MyEntry`) by adding the `new_normal()` method. - Implement `AsRef<LogId>` and `AsMut<LogId>` for your custom entry type. 2. **For applications using the default `Entry` provided by OpenRaft**: - No changes are required.
drmingdrmer
force-pushed
the
183-log-id
branch
from
25b71e0 to
67e9483
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Change: refine the
RaftEntrytraitThe
RaftEntrytrait now requiresAsRef<LogIdOf<C>>andAsMut<LogIdOf<C>>, providing a more standard API for accessing thelog ID of a log entry. As a result, the
RaftEntry: RaftLogIdrequirement is no longer needed.
A new method,
new_normal(), has been added to theRaftEntrytraitto replace the
FromAppDatatrait.Additional utility methods for working with entries are now provided
in the
RaftEntryExttrait.Part of Abstract OpenRaft Core Data Structures into Traits #1278
Upgrade tips:
For applications using a custom
RaftEntryimplementation (e.g.,declared with
declare_raft_types!(MyTypes: Entry = MyEntry)):RaftEntryimplementation for your custom entry type(
MyEntry) by adding thenew_normal()method.AsRef<LogId>andAsMut<LogId>for your custom entrytype.
For applications using the default
Entryprovided by OpenRaft:This change is