Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added SQL Server reconcile code #1403

Merged
merged 12 commits into from
Feb 4, 2025
Merged

Added SQL Server reconcile code #1403

merged 12 commits into from
Feb 4, 2025

Conversation

vijaypavann-db
Copy link
Contributor

Added SQL Server Reconciliation support in Remorph Reconcile

Currently Reconcile supports only Oracle , Snowflake and Databricks dialects.

@vijaypavann-db vijaypavann-db self-assigned this Jan 6, 2025
@vijaypavann-db vijaypavann-db marked this pull request as ready for review January 7, 2025 07:32
@vijaypavann-db vijaypavann-db requested a review from a team as a code owner January 7, 2025 07:32
@sundarshankar89
Copy link
Collaborator

Can you link Apoorvas PR here and close that

@vijaypavann-db
Copy link
Contributor Author

Refactored from PR #868

@vijaypavann-db vijaypavann-db mentioned this pull request Jan 8, 2025
Closed
@vijaypavann-db vijaypavann-db added the enhancement New feature or request label Jan 8, 2025
sundarshankar89
sundarshankar89 requested changes Jan 8, 2025
View reviewed changes
Copy link
Collaborator

@sundarshankar89 sundarshankar89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small Nit:

src/databricks/labs/remorph/reconcile/connectors/jdbc_reader.py Outdated Show resolved Hide resolved
@vijaypavann-db vijaypavann-db marked this pull request as draft January 8, 2025 08:31
@vijaypavann-db vijaypavann-db marked this pull request as ready for review January 10, 2025 07:03
bishwajit-db
bishwajit-db approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@bishwajit-db bishwajit-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sundarshankar89
sundarshankar89 approved these changes Feb 4, 2025
View reviewed changes
Copy link
Collaborator

@sundarshankar89 sundarshankar89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bishwajit-db bishwajit-db added this pull request to the merge queue Feb 4, 2025
Merged via the queue into main with commit 93f6bf5 Feb 4, 2025
5 checks passed
@bishwajit-db bishwajit-db deleted the feature/sql-server-source-impl-reconcile branch February 4, 2025 12:51
ericvergnaud added a commit that referenced this pull request Feb 6, 2025
@ericvergnaud
Merge branch 'main' into feature/lsp-installer
881ae63 
* main:
  Simplified installation journey (#1436)
  Added SQL Server reconcile code (#1403)
  Patch User Agent (#1425)

# Conflicts:
#	src/databricks/labs/remorph/install.py
#	tests/unit/test_install.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sundarshankar89 sundarshankar89 sundarshankar89 approved these changes

@bishwajit-db bishwajit-db bishwajit-db approved these changes

@sriram251-code sriram251-code Awaiting requested review from sriram251-code

Assignees

@vijaypavann-db vijaypavann-db

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vijaypavann-db @sundarshankar89 @sriram251-code @bishwajit-db