Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Teradata DDL support #1413

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Teradata DDL support #1413

wants to merge 6 commits into from

Conversation

sriram251-code
Copy link
Contributor

This PR contains the features to support Teradata DDL.

@sriram251-code sriram251-code added the enhancement New feature or request label Jan 8, 2025
@sriram251-code sriram251-code self-assigned this Jan 8, 2025
@sriram251-code sriram251-code marked this pull request as ready for review January 8, 2025 15:49
@sriram251-code sriram251-code requested a review from a team as a code owner January 8, 2025 15:49
sundarshankar89
sundarshankar89 approved these changes Jan 16, 2025
View reviewed changes
Copy link
Collaborator

@sundarshankar89 sundarshankar89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ericvergnaud
ericvergnaud requested changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@ericvergnaud ericvergnaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be contributed back to Sqlglot rather than overridden on our side ?
They make frequent releases so it wouldn't slow us down

@sundarshankar89
Copy link
Collaborator

Shouldn't this be contributed back to Sqlglot rather than overridden on our side ? They make frequent releases so it wouldn't slow us down

There is some context as to why this approach was taken. we will need to accommodate some legacy patterns till we contribute everything back to OSS Sqlglot itself.
cc: @gueniai

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericvergnaud ericvergnaud ericvergnaud requested changes

@sundarshankar89 sundarshankar89 sundarshankar89 approved these changes

Requested changes must be addressed to merge this pull request.

Assignees

@sriram251-code sriram251-code

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sriram251-code @sundarshankar89 @ericvergnaud