BEP466 #80
Open
BEP466 #80
+87
−77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Naohiro Yoshida <[email protected]>
yoshidan
force-pushed
the
feature/bep466
branch
from
19afe90 to
cd3ca85
Compare
added 2 commits
December 2, 2024 08:29
Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
yoshidan
force-pushed
the
feature/bep466
branch
from
8fa06ff to
e1a5feb
Compare
added 4 commits
January 28, 2025 18:59
Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
3100
reviewed
Jan 30, 2025
| @@ -489,6 +431,11 @@ impl TryFrom<RawETHHeader> for ETHHeader { | |||
| None | |||
| }; | |||
|
|
|||
| #[allow(clippy::absurd_extreme_comparisons)] | |||
| if PASCAL_TIMESTAMP > 0 && timestamp >= PASCAL_TIMESTAMP && requests_hash.is_none() { | |||
There was a problem hiding this comment.
When PASCAL_TIMESTAMP is 0, it's interpreted as not being Pascal, rather than indicating it's already activated.
It would be helpful to have explanatory comments near where users specify this value, to prevent misunderstandings since this behavior differs from flag management in geth and bsc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bnb-chain/bsc#2777
It's going to be Prague fork, not Pascal.
https://github.com/bnb-chain/bsc/blob/2df94c370cfa143982ae651d5b619af641b92295/params/config.go#L160