Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ingest): cleanup structured properties validation #12115

Merged
merged 2 commits into from
Dec 14, 2024
Merged

refactor(ingest): cleanup structured properties validation #12115

merged 2 commits into from
Dec 14, 2024

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Dec 12, 2024 •
edited
Loading

Reuses an existing utility + makes it thread safe.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Dec 12, 2024
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Dec 12, 2024
chriscollins3456
chriscollins3456 approved these changes Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@chriscollins3456 chriscollins3456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me

@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Dec 12, 2024
@shirshanka shirshanka merged commit 05ba403 into master Dec 14, 2024
94 of 100 checks passed
@shirshanka shirshanka deleted the structured-properties-graph branch December 14, 2024 15:12
sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Dec 17, 2024
@hsheth2 @sleeperdeep
refactor(ingest): cleanup structured properties validation (datahub-p…
35b70d7 
…roject#12115)
brock-acryl pushed a commit to brock-acryl/datahub that referenced this pull request Jan 30, 2025
@hsheth2 @chakru-r
refactor(ingest): cleanup structured properties validation (datahub-p…
9470677 
…roject#12115)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriscollins3456 chriscollins3456 chriscollins3456 approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata pending-submitter-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hsheth2 @chriscollins3456 @shirshanka